From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Cc: Corentin Labbe <clabbe.montjoie@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
<netdev@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH] net: ethernet: stmmac: properly set PS bit in MII configurations during reset
Date: Wed, 10 May 2017 09:18:17 +0200 [thread overview]
Message-ID: <20170510091817.58f4e843@free-electrons.com> (raw)
In-Reply-To: <e8151650-aa51-6713-f10c-b3663763ff78@st.com>
Hello,
On Wed, 10 May 2017 09:03:12 +0200, Giuseppe CAVALLARO wrote:
> > Please, read again my patch and the description of the problem that I
> > have sent. But basically, any solution that does not allow to set the
> > PS bit between asserting the DMA reset bit and polling for it to clear
> > will not work for MII PHYs.
>
> yes your point was clear to me, I was just wondering if we could find an
> easier way
> to solve it w/o changing the API, adding the set_ps and propagating the
> "interface"
> inside the DMA reset.
>
> Maybe this could be fixed in the glue-logic in some way. Let me know
> what do you think.
Well, it's more up to you to tell me how you would like this be solved.
We figured out what the problem was, but I don't know well enough the
architecture of the driver to decide how the solution to this problem
should be designed. I made an initial simple proposal to show what is
needed, but I'm definitely open to suggestions.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-05-10 7:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 9:45 [PATCH] net: ethernet: stmmac: properly set PS bit in MII configurations during reset Thomas Petazzoni
2017-05-02 19:00 ` David Miller
2017-05-03 8:13 ` Giuseppe CAVALLARO
2017-05-03 14:30 ` Corentin Labbe
2017-05-08 14:28 ` Giuseppe CAVALLARO
2017-05-08 19:12 ` Thomas Petazzoni
2017-05-10 7:03 ` Giuseppe CAVALLARO
2017-05-10 7:18 ` Thomas Petazzoni [this message]
2017-05-15 14:27 ` Thomas Petazzoni
2017-06-25 12:32 ` Thomas Petazzoni
2017-06-28 14:40 ` Giuseppe CAVALLARO
2017-07-29 19:54 ` Thomas Petazzoni
2017-08-02 12:33 ` Giuseppe CAVALLARO
2017-05-03 15:11 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170510091817.58f4e843@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=alexandre.torgue@st.com \
--cc=clabbe.montjoie@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.