From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 15/15] drm/i915: Simplify cursor register write sequence Date: Wed, 10 May 2017 19:38:17 +0300 Message-ID: <20170510163817.GG12629@intel.com> References: <20170327185546.2977-1-ville.syrjala@linux.intel.com> <20170327185546.2977-16-ville.syrjala@linux.intel.com> <20170505213150.GD24641@ideak-desk.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 534AF6E3A0 for ; Wed, 10 May 2017 16:38:23 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170505213150.GD24641@ideak-desk.fi.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gU2F0LCBNYXkgMDYsIDIwMTcgYXQgMTI6MzE6NTBBTSArMDMwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IE9uIE1vbiwgTWFyIDI3LCAyMDE3IGF0IDA5OjU1OjQ2UE0gKzAzMDAsIHZpbGxlLnN5cmph bGFAbGludXguaW50ZWwuY29tIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxs ZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IAo+ID4gSXQgbG9va3MgbGlrZSBzaW1wbHkg d3JpdGluZyBhbGwgdGhlIGN1cnNvciByZWdpc3RlciBldmVyeSBzaW5nbGUKPiA+IHRpbWUgbWln aHQgYmUgc2xpZ2h0bHkgZmFzdGVyIHRoYW4gY2hlY2tpbmcgdG8gc2VlIG9mIGVhY2ggb2YKPiA+ IHRoZW0gbmVlZCB0byBiZSB3cml0dGVuLiBTbyBpZiBhbnkgb3RoZXIgcmVnaXN0ZXIgYXBhcnQg ZnJvbQo+ID4gQ1VSUE9TIG5lZWRzIHRvIGJlIHdyaXR0ZW4gbGV0J3MganVzdCB3cml0ZSBhbGwg dGhlIHJlZ2lzdGVycy4KPiA+IAo+ID4gQ1VSUE9TIGlzIGxlZnQgYXMgYSBzcGVjaWFsIGNhc2Ug bWFpbmx5IGZvciA4NDUvODY1IHdoZXJlIHdlIGhhdmUgdG8KPiA+IGRpc2FibGUgdGhlIGN1cnNv ciB0byBjaGFuZ2UgbWFueSBvZiB0aGUgY3Vyc29yIHBhcmFtZXRlcnMuIFRoaXMKPiA+IGludHJv ZHVjZXMgYSBzbGlnaHQgY2hhbmNlIG9mIHRoZSBjdXJzb3IgZmxpY2tlcmluZyB3aGVuIHRoaW5n cyBnZXQKPiA+IHVwZGF0ZWQgKHNpbmNlIHdlJ3JlIG5vdCBjdXJyZW50bHkgZG9pbmcgdGhlIHZi bGFuayBldmFkZSBmb3IgY3Vyc29yCj4gPiB1cGRhdGVzKS4gSWYgd2Ugd3JpdGUgQ1VSUE9TIGFs b25lIHRoZW4gdGhhdCBvYnZpb3VzbHkgY2FuJ3QgaGFwcGVuLgo+ID4gQW5kIGxldCdzIGZvbGxv dyB0aGUgc2FtZSBwYXR0ZXJuIGluIHRoZSBpOXh4IGNvZGUganVzdCBmb3Igc3ltbWV0cnkuCj4g PiBJIHdhc24ndCBhYmxlIHRvIHNlZSBhIHNpbmdpZmljYW50IHBlcmZvcm1hbmNlIGRpZmZlcmVu Y2UgYmV0d2Vlbgo+ID4gdGhpcyBhbmQganVzdCB3cml0aW5nIGFsbCB0aGUgcmVnaXN0ZXJzIHVu Y29uZGl0aW9uYWxseS4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2 aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBSZXZpZXdlZC1ieTogSW1yZSBEZWFr IDxpbXJlLmRlYWtAaW50ZWwuY29tPgoKVGhhbmtzIGZvciB0aGUgcmV2aWV3cy4gRW50aXJlIHNl cmllcyBwdXNoZWQgdG8gZGlucS4KCj4gCj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kaXNwbGF5LmMgfCA2OSArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0t LS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwgMzUgZGVsZXRpb25zKC0p Cj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IGluZGV4IGQ3OGFi MGQzNTI3NC4uNDBhYzBmOTM4YTRlIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMKPiA+IEBAIC05MzIzLDM2ICs5MzIzLDI4IEBAIHN0YXRpYyB2b2lkIGk4NDVfdXBk YXRlX2N1cnNvcihzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLAo+ID4gIAo+ID4gIAlzcGluX2xv Y2tfaXJxc2F2ZSgmZGV2X3ByaXYtPnVuY29yZS5sb2NrLCBpcnFmbGFncyk7Cj4gPiAgCj4gPiAt CWlmIChwbGFuZS0+Y3Vyc29yLmNudGwgIT0gMCAmJgo+ID4gLQkgICAgKHBsYW5lLT5jdXJzb3Iu YmFzZSAhPSBiYXNlIHx8Cj4gPiAtCSAgICAgcGxhbmUtPmN1cnNvci5zaXplICE9IHNpemUgfHwK PiA+IC0JICAgICBwbGFuZS0+Y3Vyc29yLmNudGwgIT0gY250bCkpIHsKPiA+IC0JCS8qIE9uIHRo ZXNlIGNoaXBzZXRzIHdlIGNhbiBvbmx5IG1vZGlmeSB0aGUgYmFzZS9zaXplL3N0cmlkZQo+ID4g LQkJICogd2hpbHN0IHRoZSBjdXJzb3IgaXMgZGlzYWJsZWQuCj4gPiAtCQkgKi8KPiA+ICsJLyog T24gdGhlc2UgY2hpcHNldHMgd2UgY2FuIG9ubHkgbW9kaWZ5IHRoZSBiYXNlL3NpemUvc3RyaWRl Cj4gPiArCSAqIHdoaWxzdCB0aGUgY3Vyc29yIGlzIGRpc2FibGVkLgo+ID4gKwkgKi8KPiA+ICsJ aWYgKHBsYW5lLT5jdXJzb3IuYmFzZSAhPSBiYXNlIHx8Cj4gPiArCSAgICBwbGFuZS0+Y3Vyc29y LnNpemUgIT0gc2l6ZSB8fAo+ID4gKwkgICAgcGxhbmUtPmN1cnNvci5jbnRsICE9IGNudGwpIHsK PiA+ICAJCUk5MTVfV1JJVEVfRlcoQ1VSQ05UUihQSVBFX0EpLCAwKTsKPiA+IC0JCXBsYW5lLT5j dXJzb3IuY250bCA9IDA7Cj4gPiAtCX0KPiA+IC0KPiA+IC0JaWYgKHBsYW5lLT5jdXJzb3IuYmFz ZSAhPSBiYXNlKQo+ID4gIAkJSTkxNV9XUklURV9GVyhDVVJCQVNFKFBJUEVfQSksIGJhc2UpOwo+ ID4gLQo+ID4gLQlpZiAocGxhbmUtPmN1cnNvci5zaXplICE9IHNpemUpCj4gPiAgCQlJOTE1X1dS SVRFX0ZXKENVUlNJWkUsIHNpemUpOwo+ID4gLQo+ID4gLQlpZiAoY250bCkKPiA+ICAJCUk5MTVf V1JJVEVfRlcoQ1VSUE9TKFBJUEVfQSksIHBvcyk7Cj4gPiAtCj4gPiAtCWlmIChwbGFuZS0+Y3Vy c29yLmNudGwgIT0gY250bCkKPiA+ICAJCUk5MTVfV1JJVEVfRlcoQ1VSQ05UUihQSVBFX0EpLCBj bnRsKTsKPiA+ICAKPiA+ICsJCXBsYW5lLT5jdXJzb3IuYmFzZSA9IGJhc2U7Cj4gPiArCQlwbGFu ZS0+Y3Vyc29yLnNpemUgPSBzaXplOwo+ID4gKwkJcGxhbmUtPmN1cnNvci5jbnRsID0gY250bDsK PiA+ICsJfSBlbHNlIHsKPiA+ICsJCUk5MTVfV1JJVEVfRlcoQ1VSUE9TKFBJUEVfQSksIHBvcyk7 Cj4gPiArCX0KPiA+ICsKPiA+ICAJUE9TVElOR19SRUFEX0ZXKENVUkNOVFIoUElQRV9BKSk7Cj4g PiAgCj4gPiAgCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmRldl9wcml2LT51bmNvcmUubG9jaywg aXJxZmxhZ3MpOwo+ID4gLQo+ID4gLQlwbGFuZS0+Y3Vyc29yLmNudGwgPSBjbnRsOwo+ID4gLQlw bGFuZS0+Y3Vyc29yLmJhc2UgPSBiYXNlOwo+ID4gLQlwbGFuZS0+Y3Vyc29yLnNpemUgPSBzaXpl Owo+ID4gIH0KPiA+ICAKPiA+ICBzdGF0aWMgdm9pZCBpODQ1X2Rpc2FibGVfY3Vyc29yKHN0cnVj dCBpbnRlbF9wbGFuZSAqcGxhbmUsCj4gPiBAQCAtOTUwOCwyNyArOTUwMCwzNCBAQCBzdGF0aWMg dm9pZCBpOXh4X3VwZGF0ZV9jdXJzb3Ioc3RydWN0IGludGVsX3BsYW5lICpwbGFuZSwKPiA+ICAK PiA+ICAJc3Bpbl9sb2NrX2lycXNhdmUoJmRldl9wcml2LT51bmNvcmUubG9jaywgaXJxZmxhZ3Mp Owo+ID4gIAo+ID4gLQlpZiAocGxhbmUtPmN1cnNvci5jbnRsICE9IGNudGwpCj4gPiArCS8qCj4g PiArCSAqIE9uIHNvbWUgcGxhdGZvcm1zIHdyaXRpbmcgQ1VSQ05UUiBmaXJzdCB3aWxsIGFsc28K PiA+ICsJICogY2F1c2UgQ1VSUE9TIHRvIGJlIGFybWVkIGJ5IHRoZSBDVVJCQVNFIHdyaXRlLgo+ ID4gKwkgKiBXaXRob3V0IHRoZSBDVVJDTlRSIHdyaXRlIHRoZSBDVVJQT1Mgd3JpdGUgd291bGQK PiA+ICsJICogYXJtIGl0c2VsZi4KPiA+ICsJICoKPiA+ICsJICogQ1VSQ05UUiBhbmQgQ1VSX0ZC Q19DVEwgYXJlIGFsd2F5cwo+ID4gKwkgKiBhcm1lZCBieSB0aGUgQ1VSQkFTRSB3cml0ZSBvbmx5 Lgo+ID4gKwkgKi8KPiA+ICsJaWYgKHBsYW5lLT5jdXJzb3IuYmFzZSAhPSBiYXNlIHx8Cj4gPiAr CSAgICBwbGFuZS0+Y3Vyc29yLnNpemUgIT0gZmJjX2N0bCB8fAo+ID4gKwkgICAgcGxhbmUtPmN1 cnNvci5jbnRsICE9IGNudGwpIHsKPiA+ICAJCUk5MTVfV1JJVEVfRlcoQ1VSQ05UUihwaXBlKSwg Y250bCk7Cj4gPiAtCj4gPiAtCWlmIChwbGFuZS0+Y3Vyc29yLnNpemUgIT0gZmJjX2N0bCkKPiA+ IC0JCUk5MTVfV1JJVEVfRlcoQ1VSX0ZCQ19DVEwocGlwZSksIGZiY19jdGwpOwo+ID4gLQo+ID4g LQlpZiAoY250bCkKPiA+ICsJCWlmIChIQVNfQ1VSX0ZCQyhkZXZfcHJpdikpCj4gPiArCQkJSTkx NV9XUklURV9GVyhDVVJfRkJDX0NUTChwaXBlKSwgZmJjX2N0bCk7Cj4gPiAgCQlJOTE1X1dSSVRF X0ZXKENVUlBPUyhwaXBlKSwgcG9zKTsKPiA+IC0KPiA+IC0JaWYgKHBsYW5lLT5jdXJzb3IuY250 bCAhPSBjbnRsIHx8Cj4gPiAtCSAgICBwbGFuZS0+Y3Vyc29yLnNpemUgIT0gZmJjX2N0bCB8fAo+ ID4gLQkgICAgcGxhbmUtPmN1cnNvci5iYXNlICE9IGJhc2UpCj4gPiAgCQlJOTE1X1dSSVRFX0ZX KENVUkJBU0UocGlwZSksIGJhc2UpOwo+ID4gIAo+ID4gKwkJcGxhbmUtPmN1cnNvci5iYXNlID0g YmFzZTsKPiA+ICsJCXBsYW5lLT5jdXJzb3Iuc2l6ZSA9IGZiY19jdGw7Cj4gPiArCQlwbGFuZS0+ Y3Vyc29yLmNudGwgPSBjbnRsOwo+ID4gKwl9IGVsc2Ugewo+ID4gKwkJSTkxNV9XUklURV9GVyhD VVJQT1MocGlwZSksIHBvcyk7Cj4gPiArCX0KPiA+ICsKPiA+ICAJUE9TVElOR19SRUFEX0ZXKENV UkJBU0UocGlwZSkpOwo+ID4gIAo+ID4gIAlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZkZXZfcHJp di0+dW5jb3JlLmxvY2ssIGlycWZsYWdzKTsKPiA+IC0KPiA+IC0JcGxhbmUtPmN1cnNvci5jbnRs ID0gY250bDsKPiA+IC0JcGxhbmUtPmN1cnNvci5iYXNlID0gYmFzZTsKPiA+IC0JcGxhbmUtPmN1 cnNvci5zaXplID0gZmJjX2N0bDsKPiA+ICB9Cj4gPiAgCj4gPiAgc3RhdGljIHZvaWQgaTl4eF9k aXNhYmxlX2N1cnNvcihzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLAo+ID4gLS0gCj4gPiAyLjEw LjIKPiA+IAo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK