Re: [PATCH 0/2] Various fixes for contigmem

[Tiwei Bie <tiwei.bie@intel.com>]

On Wed, May 10, 2017 at 10:05:19PM +0800, Richardson, Bruce wrote:
> 
> > -----Original Message-----
> > From: Bie, Tiwei
> > Sent: Tuesday, May 9, 2017 9:47 AM
> > To: dev@dpdk.org
> > Cc: Richardson, Bruce <bruce.richardson@intel.com>
> > Subject: [PATCH 0/2] Various fixes for contigmem
> > 
> > Tiwei Bie (2):
> >   contigmem: free the allocated memory when error occurs
> >   contigmem: don't zero the pages during each mmap
> > 
> >  lib/librte_eal/bsdapp/contigmem/contigmem.c | 186
> > ++++++++++++++++++++++++----
> >  1 file changed, 161 insertions(+), 25 deletions(-)
> > 
> These look better solutions than the previous ones for multi-process.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Given that this is not a new bug in this release, I don't think we should take the risk of applying the patches this late in the 17.05 release cycle. I therefore suggest that they be merged for 17.08 and once tested in that release, backported to 17.05 stable.
> 

Yeah, I agree. It's not a minor change.

Best regards,
Tiwei Bie