From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: "Sekhar, Ashwin" <Ashwin.Sekhar@cavium.com>
Cc: "Jacob, Jerin" <Jerin.JacobKollanukkaran@cavium.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
"pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
"Czekaj, Maciej" <Maciej.Czekaj@cavium.com>,
"viktorin@rehivetech.com" <viktorin@rehivetech.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"jianbo.liu@linaro.org" <jianbo.liu@linaro.org>
Subject: Re: [PATCH 2/6] config: add clang support for armv8a linuxapp
Date: Thu, 11 May 2017 12:28:03 +0530 [thread overview]
Message-ID: <20170511065801.GA5461@jerin> (raw)
In-Reply-To: <1494481037.4256.6.camel@caviumnetworks.com>
-----Original Message-----
> Date: Thu, 11 May 2017 11:07:18 +0530
> From: "Sekhar, Ashwin" <Ashwin.Sekhar@cavium.com>
> To: "Jacob, Jerin" <Jerin.JacobKollanukkaran@cavium.com>
> CC: "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
> "thomas@monjalon.net" <thomas@monjalon.net>,
> "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
> "pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
> "Czekaj, Maciej" <Maciej.Czekaj@cavium.com>, "viktorin@rehivetech.com"
> <viktorin@rehivetech.com>, "dev@dpdk.org" <dev@dpdk.org>,
> "jianbo.liu@linaro.org" <jianbo.liu@linaro.org>
> Subject: Re: [dpdk-dev] [PATCH 2/6] config: add clang support for armv8a
> linuxapp
>
> <html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8">
> <meta name="Generator" content="Microsoft Exchange Server">
> <!-- converted from text -->
> <style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style></head>
> <body>
> <font size="2"><span style="font-size:10pt;"><div class="PlainText">On Thu, 2017-05-11 at 10:54 +0530, Jerin Jacob wrote:<br>
> > -----Original Message-----<br>
> > > <br>
> > > Date: Wed, 10 May 2017 03:16:39 -0700<br>
> > > From: Ashwin Sekhar T K <ashwin.sekhar@caviumnetworks.com><br>
> > > To: thomas@monjalon.net, jerin.jacob@caviumnetworks.com,<br>
> > > maciej.czekaj@caviumnetworks.com, viktorin@rehivetech.com,<br>
> > > jianbo.liu@linaro.org, bruce.richardson@intel.com,<br>
> > > pablo.de.lara.guarch@intel.com, konstantin.ananyev@intel.com<br>
> > > Cc: dev@dpdk.org, Ashwin Sekhar T K <ashwin.sekhar@caviumnetworks.c<br>
> > > om><br>
> > > Subject: [dpdk-dev] [PATCH 2/6] config: add clang support for<br>
> > > armv8a<br>
> > > linuxapp<br>
> > > X-Mailer: git-send-email 2.13.0.rc1<br>
> > > <br>
> > > Added new config arm64-armv8a-linuxapp-clang<br>
> > > <br>
> > > Signed-off-by: Ashwin Sekhar T K <ashwin.sekhar@caviumnetworks.com><br>
> > > ---<br>
> > > config/defconfig_arm64-armv8a-linuxapp-clang | 56<br>
> > > ++++++++++++++++++++++++++++<br>
> > > 1 file changed, 56 insertions(+)<br>
> > > create mode 100644 config/defconfig_arm64-armv8a-linuxapp-clang<br>
> > > <br>
> > > diff --git a/config/defconfig_arm64-armv8a-linuxapp-clang<br>
> > > b/config/defconfig_arm64-armv8a-linuxapp-clang<br>
> > > +#include "common_linuxapp"<br>
> > > +<br>
> > > +CONFIG_RTE_MACHINE="armv8a"<br>
> > > +<br>
> > > +CONFIG_RTE_ARCH="arm64"<br>
> > > +CONFIG_RTE_ARCH_ARM64=y<br>
> > > +CONFIG_RTE_ARCH_64=y<br>
> > > +<br>
> > > +CONFIG_RTE_FORCE_INTRINSICS=y<br>
> > > +<br>
> > > +CONFIG_RTE_TOOLCHAIN="clang"<br>
> > > +CONFIG_RTE_TOOLCHAIN_CLANG=y<br>
> > > +<br>
> > > +# Maximum available cache line size in arm64 implementations.<br>
> > > +# Setting to maximum available cache line size in generic config<br>
> > > +# to address minimum DMA alignment across all arm64<br>
> > > implementations.<br>
> > > +CONFIG_RTE_CACHE_LINE_SIZE=128<br>
> > > +<br>
> > > +CONFIG_RTE_EAL_IGB_UIO=n<br>
> > > +<br>
> > > +CONFIG_RTE_LIBRTE_FM10K_PMD=n<br>
> > > +CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n<br>
> > > +CONFIG_RTE_LIBRTE_AVP_PMD=n<br>
> > > +<br>
> > > +CONFIG_RTE_SCHED_VECTOR=n<br>
> > IMO, It is better to create common_armv8 config and let gcc and clang<br>
> > use that to avoid duplicating the symbols.<br>
> > <br>
> For x86, this is the convention that is followed. There are separate<br>
> defconfigs for icc, gcc, clang with symbols duplicated. Do we need to<br>
> deviate from this convention for armv8a?<br>
x86 case it bit different as the delta between common_config and x86 is very minimal.
for arm64 case, Following configs needs to be duplicated in both clang and gcc.
CONFIG_RTE_CACHE_LINE_SIZE=128
CONFIG_RTE_EAL_IGB_UIO=n
CONFIG_RTE_LIBRTE_FM10K_PMD=n
CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
CONFIG_RTE_LIBRTE_AVP_PMD=n
CONFIG_RTE_SCHED_VECTOR=n
That creates mutability issue. Creating a common common_armv8_linuxapp will
fix that issue.
next prev parent reply other threads:[~2017-05-11 6:58 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 10:16 [PATCH 0/6] add clang compilation support for armv8a linuxapp Ashwin Sekhar T K
2017-05-10 10:16 ` [PATCH 1/6] hash: compile armv8a CRC32 support conditionally Ashwin Sekhar T K
2017-05-11 5:21 ` Jerin Jacob
2017-05-11 14:33 ` [PATCH v2 0/6] Add clang compilation support for armv8a linuxapp Ashwin Sekhar T K
2017-05-11 14:33 ` [PATCH v2 1/6] hash: compile armv8a CRC32 support conditionally Ashwin Sekhar T K
2017-05-11 14:33 ` [PATCH v2 2/6] config: add clang support for armv8a linuxapp Ashwin Sekhar T K
2017-05-12 5:17 ` Jerin Jacob
2017-05-11 14:33 ` [PATCH v2 3/6] net/thunderx: fix compile errors for armv8a clang Ashwin Sekhar T K
2017-05-11 14:33 ` [PATCH v2 4/6] acl: fix warning seen with " Ashwin Sekhar T K
2017-05-11 14:33 ` [PATCH v2 5/6] eal/arm: fix warnings " Ashwin Sekhar T K
2017-05-11 14:33 ` [PATCH v2 6/6] eal: pause while busy-waiting for slave Ashwin Sekhar T K
2017-05-10 10:16 ` [PATCH 2/6] config: add clang support for armv8a linuxapp Ashwin Sekhar T K
2017-05-11 5:24 ` Jerin Jacob
2017-05-11 5:37 ` Sekhar, Ashwin
2017-05-11 6:58 ` Jerin Jacob [this message]
2017-05-10 10:16 ` [PATCH 3/6] net/thunderx: fix compile errors for armv8a clang Ashwin Sekhar T K
2017-05-11 5:28 ` Jerin Jacob
2017-05-10 10:16 ` [PATCH 4/6] acl: fix warning seen with " Ashwin Sekhar T K
2017-05-11 5:32 ` Jerin Jacob
2017-05-10 10:16 ` [PATCH 5/6] eal/arm: fix warnings " Ashwin Sekhar T K
2017-05-11 5:33 ` Jerin Jacob
2017-05-10 10:16 ` [PATCH 6/6] eal: fix warning " Ashwin Sekhar T K
2017-05-11 5:52 ` Jerin Jacob
2017-05-11 5:59 ` [PATCH 0/6] add clang compilation support for armv8a linuxapp Jerin Jacob
2017-05-11 14:09 ` Sekhar, Ashwin
2017-05-12 5:45 ` [PATCH v3 0/6] Add " Ashwin Sekhar T K
2017-05-12 5:45 ` [PATCH v3 1/6] eal: pause while busy-waiting for slave Ashwin Sekhar T K
2017-05-12 5:45 ` [PATCH v3 2/6] hash: compile armv8a CRC32 support conditionally Ashwin Sekhar T K
2017-05-12 5:45 ` [PATCH v3 3/6] net/thunderx: fix compile errors for armv8a clang Ashwin Sekhar T K
2017-05-12 5:45 ` [PATCH v3 4/6] acl: fix warning seen with " Ashwin Sekhar T K
2017-05-12 5:45 ` [PATCH v3 5/6] eal/arm: fix warnings " Ashwin Sekhar T K
2017-05-12 5:45 ` [PATCH v3 6/6] config: add clang support for armv8a linuxapp Ashwin Sekhar T K
2017-05-12 6:10 ` Jianbo Liu
2017-05-15 10:24 ` Hemant Agrawal
2017-05-15 10:29 ` [PATCH v3 0/6] Add clang compilation " Hemant Agrawal
2017-07-03 20:29 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170511065801.GA5461@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=Ashwin.Sekhar@cavium.com \
--cc=Jerin.JacobKollanukkaran@cavium.com \
--cc=Maciej.Czekaj@cavium.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jianbo.liu@linaro.org \
--cc=konstantin.ananyev@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas@monjalon.net \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.