From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1158821A13493 for ; Thu, 11 May 2017 05:07:21 -0700 (PDT) Date: Thu, 11 May 2017 14:07:18 +0200 From: Christoph Hellwig Subject: Re: [PATCH 05/16] uuid: add the v1 layout to uuid_t Message-ID: <20170511120718.GA27480@lst.de> References: <20170510180214.16852-1-hch@lst.de> <20170510180214.16852-6-hch@lst.de> <1494502838.6967.4.camel@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1494502838.6967.4.camel@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Andy Shevchenko Cc: linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, Mimi Zohar , Amir Goldstein , linux-kernel@vger.kernel.org, Steven Whitehouse , David Howells , linux-fsdevel@vger.kernel.org, Shaohua Li , Christoph Hellwig List-ID: T24gVGh1LCBNYXkgMTEsIDIwMTcgYXQgMDI6NDA6MzhQTSArMDMwMCwgQW5keSBTaGV2Y2hlbmtv IHdyb3RlOgo+IE9uIFdlZCwgMjAxNy0wNS0xMCBhdCAyMDowMiArMDIwMCwgQ2hyaXN0b3BoIEhl bGx3aWcgd3JvdGU6Cj4gPiBUdXJuIHRoZSBjb250ZW50IG9mIHV1aWRfdCBpbnRvIGEgdW5pb24g YW5kIGFkZCB0aGUgZmllbGRzIGZvciB0aGUgdjEKPiA+IGludGVycHJldGF0aW9uIHRvIGl0Lgo+ IAo+IEluIHRoZSBicmFuY2ggaXQgaGFzIGZpeCBmb3IgVVVJRCgpIHdydCB1bmlvbiBjaGFuZ2Us IGJ1dCB0aGVyZSBtaXNzZWQKPiBzaW1pbGFyIGZvciBHVUlEKCkuCgpBY3R1YWxseSBVVUlEIG5l ZWRlZCB0aGlzIGJlY2F1c2UgdXVpZF90IGhhcyBhIHVu0ZZvbiBpbnNpZGUsIEdVSUQKc2hvdWxk IG5vdCBuZWVkIGl0IGJlY2F1c2UgaXQgZG9lc24ndC4KCj4gV2hpbGUgaGVyZSwgY2FuIHdlIGlu ZGVudCBcIHRvIGJlIHRoZSBzYW1lIGFzIG9mIHRoZSByZXN0IGxpbmVzIGluCj4gbWFjcm8ocykg PwoKU3VyZS4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K TGludXgtbnZkaW1tIG1haWxpbmcgbGlzdApMaW51eC1udmRpbW1AbGlzdHMuMDEub3JnCmh0dHBz Oi8vbGlzdHMuMDEub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbnZkaW1tCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 05/16] uuid: add the v1 layout to uuid_t Date: Thu, 11 May 2017 14:07:18 +0200 Message-ID: <20170511120718.GA27480@lst.de> References: <20170510180214.16852-1-hch@lst.de> <20170510180214.16852-6-hch@lst.de> <1494502838.6967.4.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1494502838.6967.4.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Andy Shevchenko Cc: linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, Mimi Zohar , Amir Goldstein , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Steven Whitehouse , David Howells , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Shaohua Li , Christoph Hellwig List-Id: linux-raid.ids T24gVGh1LCBNYXkgMTEsIDIwMTcgYXQgMDI6NDA6MzhQTSArMDMwMCwgQW5keSBTaGV2Y2hlbmtv IHdyb3RlOgo+IE9uIFdlZCwgMjAxNy0wNS0xMCBhdCAyMDowMiArMDIwMCwgQ2hyaXN0b3BoIEhl bGx3aWcgd3JvdGU6Cj4gPiBUdXJuIHRoZSBjb250ZW50IG9mIHV1aWRfdCBpbnRvIGEgdW5pb24g YW5kIGFkZCB0aGUgZmllbGRzIGZvciB0aGUgdjEKPiA+IGludGVycHJldGF0aW9uIHRvIGl0Lgo+ IAo+IEluIHRoZSBicmFuY2ggaXQgaGFzIGZpeCBmb3IgVVVJRCgpIHdydCB1bmlvbiBjaGFuZ2Us IGJ1dCB0aGVyZSBtaXNzZWQKPiBzaW1pbGFyIGZvciBHVUlEKCkuCgpBY3R1YWxseSBVVUlEIG5l ZWRlZCB0aGlzIGJlY2F1c2UgdXVpZF90IGhhcyBhIHVu0ZZvbiBpbnNpZGUsIEdVSUQKc2hvdWxk IG5vdCBuZWVkIGl0IGJlY2F1c2UgaXQgZG9lc24ndC4KCj4gV2hpbGUgaGVyZSwgY2FuIHdlIGlu ZGVudCBcIHRvIGJlIHRoZSBzYW1lIGFzIG9mIHRoZSByZXN0IGxpbmVzIGluCj4gbWFjcm8ocykg PwoKU3VyZS4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K TGludXgtbnZkaW1tIG1haWxpbmcgbGlzdApMaW51eC1udmRpbW1AbGlzdHMuMDEub3JnCmh0dHBz Oi8vbGlzdHMuMDEub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbnZkaW1tCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:54543 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755210AbdEKMHV (ORCPT ); Thu, 11 May 2017 08:07:21 -0400 Date: Thu, 11 May 2017 14:07:18 +0200 From: Christoph Hellwig Subject: Re: [PATCH 05/16] uuid: add the v1 layout to uuid_t Message-ID: <20170511120718.GA27480@lst.de> References: <20170510180214.16852-1-hch@lst.de> <20170510180214.16852-6-hch@lst.de> <1494502838.6967.4.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1494502838.6967.4.camel@linux.intel.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Andy Shevchenko Cc: Christoph Hellwig , Amir Goldstein , linux-fsdevel@vger.kernel.org, Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org On Thu, May 11, 2017 at 02:40:38PM +0300, Andy Shevchenko wrote: > On Wed, 2017-05-10 at 20:02 +0200, Christoph Hellwig wrote: > > Turn the content of uuid_t into a union and add the fields for the v1 > > interpretation to it. > > In the branch it has fix for UUID() wrt union change, but there missed > similar for GUID(). Actually UUID needed this because uuid_t has a unіon inside, GUID should not need it because it doesn't. > While here, can we indent \ to be the same as of the rest lines in > macro(s) ? Sure. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932627AbdEKMHX (ORCPT ); Thu, 11 May 2017 08:07:23 -0400 Received: from verein.lst.de ([213.95.11.211]:54543 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755210AbdEKMHV (ORCPT ); Thu, 11 May 2017 08:07:21 -0400 Date: Thu, 11 May 2017 14:07:18 +0200 From: Christoph Hellwig To: Andy Shevchenko Cc: Christoph Hellwig , Amir Goldstein , linux-fsdevel@vger.kernel.org, Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/16] uuid: add the v1 layout to uuid_t Message-ID: <20170511120718.GA27480@lst.de> References: <20170510180214.16852-1-hch@lst.de> <20170510180214.16852-6-hch@lst.de> <1494502838.6967.4.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1494502838.6967.4.camel@linux.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 11, 2017 at 02:40:38PM +0300, Andy Shevchenko wrote: > On Wed, 2017-05-10 at 20:02 +0200, Christoph Hellwig wrote: > > Turn the content of uuid_t into a union and add the fields for the v1 > > interpretation to it. > > In the branch it has fix for UUID() wrt union change, but there missed > similar for GUID(). Actually UUID needed this because uuid_t has a unіon inside, GUID should not need it because it doesn't. > While here, can we indent \ to be the same as of the rest lines in > macro(s) ? Sure.