From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: remove duplicate 'const' annotations' Date: Thu, 11 May 2017 07:44:07 -0700 Message-ID: <20170511144406.GS3489@atomide.com> References: <20170511115059.2997141-1-arnd@arndb.de> <20170511115852.t33446wrsxedmomw@piout.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170511115852.t33446wrsxedmomw@piout.net> Sender: linux-kernel-owner@vger.kernel.org To: Alexandre Belloni Cc: Arnd Bergmann , arm@kernel.org, Nicolas Pitre , Nicolas Ferre , Russell King , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Krzysztof Halasa , Rajendra Nayak , Paul Walmsley , Viresh Kumar , Wenyou Yang , Olof Johansson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org List-Id: linux-omap@vger.kernel.org * Alexandre Belloni [170511 05:02]: > On 11/05/2017 at 13:50:16 +0200, Arnd Bergmann wrote: > > gcc-7 warns about some declarations that are more 'const' than necessary: > > > > arch/arm/mach-at91/pm.c:338:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier] > > static const struct of_device_id const ramc_ids[] __initconst = { > > arch/arm/mach-bcm/bcm_kona_smc.c:36:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier] > > static const struct of_device_id const bcm_kona_smc_ids[] __initconst = { > > arch/arm/mach-spear/time.c:207:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier] > > static const struct of_device_id const timer_of_match[] __initconst = { > > arch/arm/mach-omap2/prm_common.c:714:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier] > > static const struct of_device_id const omap_prcm_dt_match_table[] __initconst = { > > arch/arm/mach-omap2/vc.c:562:35: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier] > > static const struct i2c_init_data const omap4_i2c_timing_data[] __initconst = { > > > > The ones in arch/arm were apparently all introduced accidentally by one > > commit that correctly marked a lot of variables as __initconst. > > > > Cc: Nicolas Pitre > > Fixes: 19c233b79d1a ("ARM: appropriate __init annotation for const data") > > Signed-off-by: Arnd Bergmann > Acked-by: Alexandre Belloni Acked-by: Tony Lindgren From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Thu, 11 May 2017 07:44:07 -0700 Subject: [PATCH] ARM: remove duplicate 'const' annotations' In-Reply-To: <20170511115852.t33446wrsxedmomw@piout.net> References: <20170511115059.2997141-1-arnd@arndb.de> <20170511115852.t33446wrsxedmomw@piout.net> Message-ID: <20170511144406.GS3489@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Alexandre Belloni [170511 05:02]: > On 11/05/2017 at 13:50:16 +0200, Arnd Bergmann wrote: > > gcc-7 warns about some declarations that are more 'const' than necessary: > > > > arch/arm/mach-at91/pm.c:338:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier] > > static const struct of_device_id const ramc_ids[] __initconst = { > > arch/arm/mach-bcm/bcm_kona_smc.c:36:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier] > > static const struct of_device_id const bcm_kona_smc_ids[] __initconst = { > > arch/arm/mach-spear/time.c:207:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier] > > static const struct of_device_id const timer_of_match[] __initconst = { > > arch/arm/mach-omap2/prm_common.c:714:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier] > > static const struct of_device_id const omap_prcm_dt_match_table[] __initconst = { > > arch/arm/mach-omap2/vc.c:562:35: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier] > > static const struct i2c_init_data const omap4_i2c_timing_data[] __initconst = { > > > > The ones in arch/arm were apparently all introduced accidentally by one > > commit that correctly marked a lot of variables as __initconst. > > > > Cc: Nicolas Pitre > > Fixes: 19c233b79d1a ("ARM: appropriate __init annotation for const data") > > Signed-off-by: Arnd Bergmann > Acked-by: Alexandre Belloni Acked-by: Tony Lindgren