From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F2FD921A04E1D for ; Thu, 11 May 2017 08:36:53 -0700 (PDT) Date: Thu, 11 May 2017 09:36:52 -0600 From: Ross Zwisler Subject: Re: [PATCH] filesystem-dax: fix broken __dax_zero_page_range() conversion Message-ID: <20170511153652.GB22811@linux.intel.com> References: <149447098770.22897.1499086717635335664.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <149447098770.22897.1499086717635335664.stgit@dwillia2-desk3.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, Jan Kara , linux-fsdevel@vger.kernel.org, Christoph Hellwig List-ID: On Wed, May 10, 2017 at 07:49:47PM -0700, Dan Williams wrote: > The conversion of __dax_zero_page_range() to 'struct dax_operations' > caused it to frequently fail. The mistake was treating the @size > parameter as a dax mapping length rather than just a length of the > clear_pmem() operation. The dax mapping length is assumed to be hard > coded as PAGE_SIZE. > > Without this fix any page unaligned zeroing request will trigger a > -EINVAL return from bdev_dax_pgoff(). > > Cc: Jan Kara > Cc: Christoph Hellwig > Reported-by: Ross Zwisler Yep, this solves the issue for me. Thanks! Tested-by: Ross Zwisler > Fixes: cccbce671582 ("filesystem-dax: convert to dax_direct_access()") > Signed-off-by: Dan Williams > --- > fs/dax.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/dax.c b/fs/dax.c > index ce9dc9c3e829..5ee1d212d81f 100644 > --- a/fs/dax.c > +++ b/fs/dax.c > @@ -971,12 +971,12 @@ int __dax_zero_page_range(struct block_device *bdev, > void *kaddr; > pfn_t pfn; > > - rc = bdev_dax_pgoff(bdev, sector, size, &pgoff); > + rc = bdev_dax_pgoff(bdev, sector, PAGE_SIZE, &pgoff); > if (rc) > return rc; > > id = dax_read_lock(); > - rc = dax_direct_access(dax_dev, pgoff, PHYS_PFN(size), &kaddr, > + rc = dax_direct_access(dax_dev, pgoff, 1, &kaddr, > &pfn); > if (rc < 0) { > dax_read_unlock(id); > _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 11 May 2017 09:36:52 -0600 From: Ross Zwisler To: Dan Williams Cc: linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ross Zwisler , Christoph Hellwig , Jan Kara Subject: Re: [PATCH] filesystem-dax: fix broken __dax_zero_page_range() conversion Message-ID: <20170511153652.GB22811@linux.intel.com> References: <149447098770.22897.1499086717635335664.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <149447098770.22897.1499086717635335664.stgit@dwillia2-desk3.amr.corp.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Wed, May 10, 2017 at 07:49:47PM -0700, Dan Williams wrote: > The conversion of __dax_zero_page_range() to 'struct dax_operations' > caused it to frequently fail. The mistake was treating the @size > parameter as a dax mapping length rather than just a length of the > clear_pmem() operation. The dax mapping length is assumed to be hard > coded as PAGE_SIZE. > > Without this fix any page unaligned zeroing request will trigger a > -EINVAL return from bdev_dax_pgoff(). > > Cc: Jan Kara > Cc: Christoph Hellwig > Reported-by: Ross Zwisler Yep, this solves the issue for me. Thanks! Tested-by: Ross Zwisler > Fixes: cccbce671582 ("filesystem-dax: convert to dax_direct_access()") > Signed-off-by: Dan Williams > --- > fs/dax.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/dax.c b/fs/dax.c > index ce9dc9c3e829..5ee1d212d81f 100644 > --- a/fs/dax.c > +++ b/fs/dax.c > @@ -971,12 +971,12 @@ int __dax_zero_page_range(struct block_device *bdev, > void *kaddr; > pfn_t pfn; > > - rc = bdev_dax_pgoff(bdev, sector, size, &pgoff); > + rc = bdev_dax_pgoff(bdev, sector, PAGE_SIZE, &pgoff); > if (rc) > return rc; > > id = dax_read_lock(); > - rc = dax_direct_access(dax_dev, pgoff, PHYS_PFN(size), &kaddr, > + rc = dax_direct_access(dax_dev, pgoff, 1, &kaddr, > &pfn); > if (rc < 0) { > dax_read_unlock(id); > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756916AbdEKPhW (ORCPT ); Thu, 11 May 2017 11:37:22 -0400 Received: from mga14.intel.com ([192.55.52.115]:14533 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756243AbdEKPgy (ORCPT ); Thu, 11 May 2017 11:36:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,324,1491289200"; d="scan'208";a="259951105" Date: Thu, 11 May 2017 09:36:52 -0600 From: Ross Zwisler To: Dan Williams Cc: linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ross Zwisler , Christoph Hellwig , Jan Kara Subject: Re: [PATCH] filesystem-dax: fix broken __dax_zero_page_range() conversion Message-ID: <20170511153652.GB22811@linux.intel.com> Mail-Followup-To: Ross Zwisler , Dan Williams , linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Jan Kara References: <149447098770.22897.1499086717635335664.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <149447098770.22897.1499086717635335664.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 10, 2017 at 07:49:47PM -0700, Dan Williams wrote: > The conversion of __dax_zero_page_range() to 'struct dax_operations' > caused it to frequently fail. The mistake was treating the @size > parameter as a dax mapping length rather than just a length of the > clear_pmem() operation. The dax mapping length is assumed to be hard > coded as PAGE_SIZE. > > Without this fix any page unaligned zeroing request will trigger a > -EINVAL return from bdev_dax_pgoff(). > > Cc: Jan Kara > Cc: Christoph Hellwig > Reported-by: Ross Zwisler Yep, this solves the issue for me. Thanks! Tested-by: Ross Zwisler > Fixes: cccbce671582 ("filesystem-dax: convert to dax_direct_access()") > Signed-off-by: Dan Williams > --- > fs/dax.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/dax.c b/fs/dax.c > index ce9dc9c3e829..5ee1d212d81f 100644 > --- a/fs/dax.c > +++ b/fs/dax.c > @@ -971,12 +971,12 @@ int __dax_zero_page_range(struct block_device *bdev, > void *kaddr; > pfn_t pfn; > > - rc = bdev_dax_pgoff(bdev, sector, size, &pgoff); > + rc = bdev_dax_pgoff(bdev, sector, PAGE_SIZE, &pgoff); > if (rc) > return rc; > > id = dax_read_lock(); > - rc = dax_direct_access(dax_dev, pgoff, PHYS_PFN(size), &kaddr, > + rc = dax_direct_access(dax_dev, pgoff, 1, &kaddr, > &pfn); > if (rc < 0) { > dax_read_unlock(id); >