From: Tony Lindgren <tony@atomide.com>
To: Bin Liu <b-liu@ti.com>,
Moreno Bartalucci <moreno.bartalucci@tecnorama.it>,
Lars Melin <larsm17@gmail.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alessio Igor Bogani <abogani@kernel.org>
Subject: Re: [PATCH] usb-musb: keep VBUS on when device is disconnected
Date: Thu, 11 May 2017 13:27:27 -0700 [thread overview]
Message-ID: <20170511202726.GZ3489@atomide.com> (raw)
In-Reply-To: <20170511202306.GY3489@atomide.com>
* Tony Lindgren <tony@atomide.com> [170511 13:26]:
> diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
> --- a/drivers/usb/musb/musb_dsps.c
> +++ b/drivers/usb/musb/musb_dsps.c
> @@ -270,6 +270,10 @@ static int dsps_check_status(struct musb *musb, void *unused)
> musb_writel(musb->ctrl_base, wrp->coreintr_set,
> MUSB_INTR_VBUSERROR << wrp->usb_shift);
> break;
> + case OTG_STATE_A_HOST:
> + if (glue->vbus_irq)
> + dsps_mod_timer(glue, 20000); /* 20s */
> + break;
> default:
> break;
> }
> --
Heh that's the wrong way around.. I think we can leave out the check
for vbus_irq.
8< ---------------
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
--- a/drivers/usb/musb/musb_dsps.c
+++ b/drivers/usb/musb/musb_dsps.c
@@ -270,6 +270,10 @@ static int dsps_check_status(struct musb *musb, void *unused)
musb_writel(musb->ctrl_base, wrp->coreintr_set,
MUSB_INTR_VBUSERROR << wrp->usb_shift);
break;
+ case OTG_STATE_A_HOST:
+ /* Keep VBUS on after disconnect for 20 seconds */
+ dsps_mod_timer(glue, 20000);
+ break;
default:
break;
}
--
2.13.0
next prev parent reply other threads:[~2017-05-11 20:27 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 14:08 [PATCH] usb-musb: keep VBUS on when device is disconnected Moreno Bartalucci
2017-03-15 14:08 ` Moreno Bartalucci
[not found] ` <20170315140801.97230-1-moreno.bartalucci-Hj/TeGiWV4YL5bzFcGmneg@public.gmane.org>
2017-03-24 18:58 ` Bin Liu
2017-03-24 18:58 ` Bin Liu
2017-03-25 7:21 ` Lars Melin
[not found] ` <2d10809f-d482-ffa9-30b7-8785e94ab102-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-27 12:53 ` Moreno Bartalucci
2017-03-27 12:53 ` Moreno Bartalucci
[not found] ` <00882633-3F61-4010-A4D2-D04473282B10-Hj/TeGiWV4YL5bzFcGmneg@public.gmane.org>
2017-03-27 13:17 ` Bin Liu
2017-03-27 13:17 ` Bin Liu
2017-03-27 14:30 ` Tony Lindgren
2017-03-27 16:20 ` Moreno Bartalucci
[not found] ` <63FD9E13-2B70-485C-80A7-206BEC16905A-Hj/TeGiWV4YL5bzFcGmneg@public.gmane.org>
2017-03-27 16:59 ` Tony Lindgren
2017-03-27 16:59 ` Tony Lindgren
2017-03-27 17:15 ` Bin Liu
2017-03-27 17:55 ` Tony Lindgren
2017-03-27 17:55 ` Tony Lindgren
2017-05-11 18:50 ` Bin Liu
2017-05-11 18:55 ` Tony Lindgren
2017-05-11 19:01 ` Bin Liu
2017-05-11 19:10 ` Bin Liu
2017-05-11 19:20 ` Bin Liu
2017-05-11 19:38 ` Tony Lindgren
2017-05-11 20:02 ` Bin Liu
2017-05-11 20:23 ` Tony Lindgren
2017-05-11 20:27 ` Tony Lindgren [this message]
2017-05-11 20:44 ` Bin Liu
2017-05-11 21:06 ` Tony Lindgren
2017-05-12 13:40 ` Bin Liu
2017-05-12 14:58 ` Tony Lindgren
2017-05-12 15:21 ` Bin Liu
2017-05-12 15:43 ` Moreno Bartalucci
2017-05-12 17:21 ` Tony Lindgren
2017-05-12 17:40 ` Bin Liu
2017-05-12 17:46 ` Tony Lindgren
2017-05-15 7:07 ` Moreno Bartalucci
2017-05-15 12:24 ` Bin Liu
2017-03-28 6:10 ` Moreno Bartalucci
2017-03-28 6:10 ` Moreno Bartalucci
[not found] ` <11BBAEC7-0B26-40FE-963E-811F7853F2FE-Hj/TeGiWV4YL5bzFcGmneg@public.gmane.org>
2017-03-28 14:59 ` Tony Lindgren
2017-03-28 14:59 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170511202726.GZ3489@atomide.com \
--to=tony@atomide.com \
--cc=abogani@kernel.org \
--cc=b-liu@ti.com \
--cc=larsm17@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=moreno.bartalucci@tecnorama.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.