All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Matthew Giassa <matthew@giassa.net>
Cc: hdegoede@redhat.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation and line width
Date: Fri, 12 May 2017 11:30:08 +0200	[thread overview]
Message-ID: <20170512093008.GA19482@kroah.com> (raw)
In-Reply-To: <1494553524-26385-5-git-send-email-matthew@giassa.net>

On Thu, May 11, 2017 at 06:45:24PM -0700, Matthew Giassa wrote:
> +#define	REG_INT_MIG_8723B		0x0304	/* Interrupt Migration */
> +#define	REG_BCNQ_DESA_8723B		0x0308	/* TX Beacon Descriptor Address
> +						 */
> +#define	REG_HQ_DESA_8723B		0x0310	/* TX High Queue Descriptor
> +						 * Address
> +						 */

Ick, that looks worse to me now, doesn't it to you?  Please leave the
original as-is.

Also, always test-build your patches :)

thanks,

greg k-h

  parent reply	other threads:[~2017-05-12  9:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-12  1:45 [PATCH 0/4] staging: rtl8723bs: resolve checkpatch issues Matthew Giassa
2017-05-12  1:45 ` [PATCH 1/4] staging: rtl8723bs: checkpatch - remove multiple blank lines Matthew Giassa
2017-05-12  1:45 ` [PATCH 2/4] staging: rtl8723bs: checkpatch - remove mixed spaces/hard-tabs Matthew Giassa
2017-05-12  1:45 ` [PATCH 3/4] staging: rtl8723bs: checkpatch - fix typos in comments Matthew Giassa
2017-05-12  1:45 ` [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation and line width Matthew Giassa
2017-05-12  3:53   ` kbuild test robot
2017-05-12  9:30   ` Greg KH [this message]
2017-05-12 12:57     ` Matthew Giassa
2017-05-12 13:24       ` Matthew Giassa
2017-05-12 13:54         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170512093008.GA19482@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@giassa.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.