From: Tony Lindgren <tony@atomide.com>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jon Hunter <jonathanh@nvidia.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Chris Healy <Chris.Healy@zii.aero>,
Jeff.White@zii.aero
Subject: Re: [PATCH] pinctrl: when claiming hog, skip maps not served by same device
Date: Fri, 12 May 2017 07:03:19 -0700 [thread overview]
Message-ID: <20170512140319.GD3489@atomide.com> (raw)
In-Reply-To: <df9e82c4-10ef-55c2-abc9-de315dee73da@cogentembedded.com>
* Nikita Yushchenko <nikita.yoush@cogentembedded.com> [170512 01:22]:
> >> + /*
> >> + * If pctldev is not null, we are claiming hog for it,
> >> + * that means, setting that is served by pctldev by itself.
> >> + *
> >> + * Thus we must skip map that is for this device but is served
> >> + * by other device.
> >> + */
> >> + if (pctldev &&
> >> + strcmp(dev_name(pctldev->dev), map->ctrl_dev_name))
> >> + continue;
> >>
> >> ret = add_setting(p, pctldev, map);
> >> /*
> >> --
> >
> > Maybe add a comment saying pctldev is NULL in the regular case
> > and only exists in the hog case?
>
> Isn't comment above saying exactly that?
Yes it is, you're right :)
Tony
next prev parent reply other threads:[~2017-05-12 14:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 20:02 [PATCH] pinctrl: when claiming hog, skip maps not served by same device Nikita Yushchenko
2017-05-11 21:44 ` Tony Lindgren
2017-05-12 8:19 ` Nikita Yushchenko
2017-05-12 14:03 ` Tony Lindgren [this message]
2017-05-22 15:07 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170512140319.GD3489@atomide.com \
--to=tony@atomide.com \
--cc=Chris.Healy@zii.aero \
--cc=Jeff.White@zii.aero \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=nikita.yoush@cogentembedded.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.