From mboxrd@z Thu Jan 1 00:00:00 1970 From: jacob pan Subject: Re: [RFC PATCH 2/8] iommu/vt-d: add bind_pasid_table function Date: Mon, 15 May 2017 06:14:22 -0700 Message-ID: <20170515061422.0000350b@intel.com> References: <1493201525-14418-1-git-send-email-yi.l.liu@intel.com> <1493201525-14418-3-git-send-email-yi.l.liu@intel.com> <20170512155929.66809113@t450s.home> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170512155929.66809113-1yVPhWWZRC1BDLzU/O5InQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Alex Williamson Cc: tianyu.lan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, "Liu, Yi L" , kevin.tian-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, jacob.jun.pan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Fri, 12 May 2017 15:59:29 -0600 Alex Williamson wrote: > > + if (pasidt_binfo->size >= intel_iommu_get_pts(iommu)) { > > + pr_err("Invalid gPASID table size %llu, host size > > %lu\n", > > + pasidt_binfo->size, > > + intel_iommu_get_pts(iommu)); > > + ret = -EINVAL; > > + goto out; > > equal is not valid? you are right, equal is valid. I was thinking of shared PASID space between guest and host but that is not the case here. The rest of your comments are taken too, thanks for the review. Jacob From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dAFpW-0006VE-Nf for qemu-devel@nongnu.org; Mon, 15 May 2017 09:14:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dAFpS-0005fx-PT for qemu-devel@nongnu.org; Mon, 15 May 2017 09:14:30 -0400 Received: from mga02.intel.com ([134.134.136.20]:65105) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dAFpS-0005fO-Gv for qemu-devel@nongnu.org; Mon, 15 May 2017 09:14:26 -0400 Date: Mon, 15 May 2017 06:14:22 -0700 From: jacob pan Message-ID: <20170515061422.0000350b@intel.com> In-Reply-To: <20170512155929.66809113@t450s.home> References: <1493201525-14418-1-git-send-email-yi.l.liu@intel.com> <1493201525-14418-3-git-send-email-yi.l.liu@intel.com> <20170512155929.66809113@t450s.home> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 2/8] iommu/vt-d: add bind_pasid_table function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: "Liu, Yi L" , kvm@vger.kernel.org, iommu@lists.linux-foundation.org, peterx@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org, kevin.tian@intel.com, ashok.raj@intel.com, tianyu.lan@intel.com, jean-philippe.brucker@arm.com, Jacob Pan , "Liu, Yi L" , jacob.jun.pan@intel.com On Fri, 12 May 2017 15:59:29 -0600 Alex Williamson wrote: > > + if (pasidt_binfo->size >= intel_iommu_get_pts(iommu)) { > > + pr_err("Invalid gPASID table size %llu, host size > > %lu\n", > > + pasidt_binfo->size, > > + intel_iommu_get_pts(iommu)); > > + ret = -EINVAL; > > + goto out; > > equal is not valid? you are right, equal is valid. I was thinking of shared PASID space between guest and host but that is not the case here. The rest of your comments are taken too, thanks for the review. Jacob