From: Peter Xu <peterx@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>,
"Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] exec: rename resolve_subpage
Date: Mon, 15 May 2017 20:16:20 +0800 [thread overview]
Message-ID: <20170515121620.GD31572@pxdev.xzpeter.org> (raw)
In-Reply-To: <6c4a5786-0ac0-4e25-9398-cd233dce7c17@redhat.com>
On Mon, May 15, 2017 at 11:03:49AM +0200, Paolo Bonzini wrote:
>
>
> On 15/05/2017 10:50, Peter Xu wrote:
> > It is not easy for people to know "what this parameter does" before
> > knowing "what is subpage". Let's use "is_mmio" to make it easier to
> > understand.
> >
> > Signed-off-by: Peter Xu <peterx@redhat.com>
>
> Maybe invert the direction and call it for_iotlb?
I wasn't aware that tcg is using resolve_subpage==false always. Then
at least is_mmio does not suite here. I am not sure whether for-iotlb
suites here either... So maybe I will just drop this patch as well,
just like patch 3.
Thanks for reviewing it!
--
Peter Xu
next prev parent reply other threads:[~2017-05-15 12:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 8:50 [Qemu-devel] [PATCH 0/4] exec: address space translation cleanups Peter Xu
2017-05-15 8:50 ` [Qemu-devel] [PATCH 1/4] exec: simplify phys_page_find() params Peter Xu
2017-05-16 2:53 ` David Gibson
2017-05-16 10:02 ` Paolo Bonzini
2017-05-15 8:50 ` [Qemu-devel] [PATCH 2/4] exec: rename resolve_subpage Peter Xu
2017-05-15 9:03 ` Paolo Bonzini
2017-05-15 12:16 ` Peter Xu [this message]
2017-05-15 8:50 ` [Qemu-devel] [PATCH 3/4] exec: further use is_mmio Peter Xu
2017-05-15 9:04 ` Paolo Bonzini
2017-05-15 9:29 ` Peter Xu
2017-05-15 8:51 ` [Qemu-devel] [PATCH 4/4] exec: abstract address_space_do_translate() Peter Xu
2017-05-16 13:24 ` [Qemu-devel] [PATCH 0/4] exec: address space translation cleanups Maxime Coquelin
2017-05-16 16:51 ` Maxime Coquelin
2017-05-16 16:54 ` Paolo Bonzini
2017-05-16 17:01 ` Maxime Coquelin
2017-05-17 4:23 ` Peter Xu
2017-05-17 5:57 ` Peter Xu
2017-05-17 7:17 ` Maxime Coquelin
2017-05-17 7:26 ` Paolo Bonzini
2017-05-17 8:38 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515121620.GD31572@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.