From: Pascal Mazon <pascal.mazon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Shepard Siegel <shepard.siegel@atomicrules.com>,
Ed Czeck <ed.czeck@atomicrules.com>,
John Miller <john.miller@atomicrules.com>,
John McNamara <john.mcnamara@intel.com>,
Harish Patil <harish.patil@cavium.com>,
Rasesh Mody <rasesh.mody@cavium.com>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Shreyansh Jain <shreyansh.jain@nxp.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Marcin Wojtas <mw@semihalf.com>,
Michal Krawczyk <mk@semihalf.com>,
Guy Tzalik <gtzalik@amazon.com>,
Evgeny Schemeilin <evgenys@amazon.com>,
Jing Chen <jing.d.chen@intel.com>,
Helin Zhang <helin.zhang@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
Matej Vido <vido@cesnet.cz>,
Yuanhan Liu <yuanhan.liu@linux.intel.com>,
Ma
Subject: Re: [PATCH v2] drivers/net: document missing speed capabilities feature
Date: Mon, 15 May 2017 14:17:07 +0200 [thread overview]
Message-ID: <20170515141707.3021bd9b@paques.dev.6wind.com> (raw)
In-Reply-To: <20170515105946.88233-1-ferruh.yigit@intel.com>
Hi,
In the case of tap PMD, I would say it's rather partially supported (P).
Best regards,
Pascal
On Mon, 15 May 2017 11:59:46 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>
> Please fix partially support to fully supported speed capabilities.
>
> Please check other features of PMD and document missing ones in features
> file.
>
> Thanks.
>
> v2:
> * Mark PMDs that return speed capabilities without checking real
> hardware capabilities to Partially supported "P".
> * Mark PMDs return fake speed capabilities to "P", like virtio and
> vmxnet3.
> ---
> doc/guides/nics/features/ark.ini | 1 +
> doc/guides/nics/features/bnx2x.ini | 1 +
> doc/guides/nics/features/bnx2x_vf.ini | 1 +
> doc/guides/nics/features/cxgbe.ini | 1 +
> doc/guides/nics/features/dpaa2.ini | 1 +
> doc/guides/nics/features/e1000.ini | 1 +
> doc/guides/nics/features/ena.ini | 1 +
> doc/guides/nics/features/fm10k.ini | 1 +
> doc/guides/nics/features/fm10k_vec.ini | 1 +
> doc/guides/nics/features/fm10k_vf.ini | 1 +
> doc/guides/nics/features/fm10k_vf_vec.ini | 1 +
> doc/guides/nics/features/i40e.ini | 1 +
> doc/guides/nics/features/i40e_vec.ini | 1 +
> doc/guides/nics/features/igb.ini | 1 +
> doc/guides/nics/features/ixgbe.ini | 1 +
> doc/guides/nics/features/ixgbe_vec.ini | 1 +
> doc/guides/nics/features/mlx4.ini | 1 +
> doc/guides/nics/features/szedata2.ini | 1 +
> doc/guides/nics/features/tap.ini | 2 +-
> doc/guides/nics/features/virtio.ini | 1 +
> doc/guides/nics/features/virtio_vec.ini | 1 +
> doc/guides/nics/features/vmxnet3.ini | 1 +
> 22 files changed, 22 insertions(+), 1 deletion(-)
[...]
> diff --git a/doc/guides/nics/features/tap.ini b/doc/guides/nics/features/tap.ini
> index 3efae75..d410409 100644
> --- a/doc/guides/nics/features/tap.ini
> +++ b/doc/guides/nics/features/tap.ini
> @@ -4,6 +4,7 @@
> ; Refer to default.ini for the full list of available PMD features.
> ;
> [Features]
> +Speed capabilities = Y
> Link status = Y
> Link status event = Y
> Jumbo frame = Y
> @@ -13,7 +14,6 @@ Basic stats = Y
> Flow API = Y
> MTU update = Y
> Multicast MAC filter = Y
> -Speed capabilities = Y
> Unicast MAC filter = Y
> Packet type parsing = Y
> Flow control = Y
[...]
next prev parent reply other threads:[~2017-05-15 12:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 13:10 [PATCH] drivers/net: document missing speed capabilities feature Ferruh Yigit
2017-05-10 13:49 ` Mcnamara, John
2017-05-10 13:51 ` Thomas Monjalon
2017-05-12 10:49 ` Ferruh Yigit
2017-05-12 15:48 ` Thomas Monjalon
2017-05-15 8:40 ` Ferruh Yigit
2017-05-15 9:33 ` Thomas Monjalon
2017-05-16 9:39 ` Alejandro Lucero
2017-05-16 10:02 ` Thomas Monjalon
2017-05-16 10:17 ` Alejandro Lucero
2017-05-15 10:59 ` [PATCH v2] " Ferruh Yigit
2017-05-15 12:17 ` Pascal Mazon [this message]
2017-05-15 12:23 ` Ferruh Yigit
2017-05-15 12:30 ` [PATCH v3] " Ferruh Yigit
2017-05-17 13:28 ` Mcnamara, John
2017-06-12 15:48 ` Ferruh Yigit
2017-05-16 9:00 ` [PATCH v2] " Mcnamara, John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515141707.3021bd9b@paques.dev.6wind.com \
--to=pascal.mazon@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=ed.czeck@atomicrules.com \
--cc=evgenys@amazon.com \
--cc=ferruh.yigit@intel.com \
--cc=gtzalik@amazon.com \
--cc=harish.patil@cavium.com \
--cc=helin.zhang@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jing.d.chen@intel.com \
--cc=jingjing.wu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=john.miller@atomicrules.com \
--cc=konstantin.ananyev@intel.com \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rasesh.mody@cavium.com \
--cc=shepard.siegel@atomicrules.com \
--cc=shreyansh.jain@nxp.com \
--cc=vido@cesnet.cz \
--cc=wenzhuo.lu@intel.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.