From: Al Viro <viro@ZenIV.linux.org.uk>
To: Richard Weinberger <richard@nod.at>
Cc: Eric Biggers <ebiggers3@gmail.com>,
linux-fscrypt@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Eric Biggers <ebiggers@google.com>, Theodore Ts'o <tytso@mit.edu>,
David Gstir <david@sigma-star.at>,
David Oberhollenzer <david.oberhollenzer@sigma-star.at>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Artem Bityutskiy <dedekind1@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: Question on fscrypt_d_revalidate() and fstest generic/429
Date: Tue, 16 May 2017 00:50:36 +0100 [thread overview]
Message-ID: <20170515235035.GO390@ZenIV.linux.org.uk> (raw)
In-Reply-To: <489e1437-990f-3e88-d426-b47b82441009@nod.at>
On Mon, May 15, 2017 at 09:51:03PM +0200, Richard Weinberger wrote:
> > I doubt it's the right solution to make fscrypt_d_revalidate() look at
> > ->i_nlink, since ->d_revalidate() is meant to validate the filename, not the
> > inode. I think there is probably a VFS bug that is causing the dentries to not
> > be freed.
>
> Not sure. Al? :-)
What's to tell VFS that they are garbage? If your code doesn't do it,
VFS has no way to know. And I certainly agree that using ->d_revalidate()
to trigger their unhashing is a bloody odd design; take it up with whoever
had come up with it...
next prev parent reply other threads:[~2017-05-15 23:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 14:39 Question on fscrypt_d_revalidate() and fstest generic/429 Richard Weinberger
2017-05-15 19:45 ` Eric Biggers
2017-05-15 19:51 ` Richard Weinberger
2017-05-15 23:25 ` Eric Biggers
2017-05-16 6:47 ` Richard Weinberger
2017-05-16 22:07 ` Eric Biggers
2017-05-16 22:27 ` Richard Weinberger
2017-05-15 23:50 ` Al Viro [this message]
2017-05-16 11:22 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515235035.GO390@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=adrian.hunter@intel.com \
--cc=david.oberhollenzer@sigma-star.at \
--cc=david@sigma-star.at \
--cc=dedekind1@gmail.com \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.