From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>,
List Linux RDMA Mailing
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] ib_core: Enable and expose force_mr module parameter
Date: Tue, 16 May 2017 07:42:56 +0200 [thread overview]
Message-ID: <20170516054256.GA4013@lst.de> (raw)
In-Reply-To: <AE3152CC-B7C8-4C51-ADDE-C3822533BB94-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
On Mon, May 15, 2017 at 01:22:59PM -0400, Chuck Lever wrote:
> In this case, the module parameter is global: one has to take
> some care when there are multiple HCAs in a system and they
> each have different MEMMGT capabilities. Instead of removing
> the setting altogether, one might replace it with a driver-
> mediated per-device-port attribute.
>
> I will let Sagi and Christoph have the last word.
I think I only added it on requests from someone (you?), and when
writing the code debugged it by manually forcing it to on. Thay
being said a module parameter is entirely trivial and thus I'm fine
with it. Think like debugfs or per-device setting for such a trivial
debug tool have just way to much boilerplate code.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-05-16 5:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 14:52 [PATCH] ib_core: Enable and expose force_mr module parameter Chuck Lever
[not found] ` <20170515145203.10708.16921.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2017-05-15 14:57 ` Leon Romanovsky
[not found] ` <20170515145757.GI3616-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-05-15 15:09 ` Chuck Lever
[not found] ` <02AFF424-A387-47F7-BD24-61C7734B9008-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-05-15 17:00 ` Leon Romanovsky
[not found] ` <20170515170021.GJ3616-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-05-15 17:22 ` Chuck Lever
[not found] ` <AE3152CC-B7C8-4C51-ADDE-C3822533BB94-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-05-15 17:46 ` Jason Gunthorpe
[not found] ` <20170515174646.GC6229-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-05-15 18:55 ` Leon Romanovsky
2017-05-16 5:42 ` Christoph Hellwig [this message]
[not found] ` <20170516054256.GA4013-jcswGhMUV9g@public.gmane.org>
2017-05-16 7:22 ` Sagi Grimberg
[not found] ` <d46b0a41-92c2-2ce2-5cf2-ac5c6c3811cd-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-05-16 14:57 ` Chuck Lever
-- strict thread matches above, loose matches on Subject: below --
2017-06-19 15:26 Chuck Lever
[not found] ` <20170619152351.2866.11046.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2017-06-19 15:30 ` Christoph Hellwig
2017-06-20 7:24 ` Sagi Grimberg
2017-06-20 7:32 ` Leon Romanovsky
[not found] ` <20170620073236.GO17846-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-06-20 15:43 ` Chuck Lever
[not found] ` <DE0C511C-A4CB-4D76-8BA7-6BFF81F590B3-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-06-20 18:03 ` Leon Romanovsky
[not found] ` <20170620180348.GV17846-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-06-20 18:23 ` Chuck Lever
[not found] ` <C27E2410-44B7-451E-8069-DF1444048158-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-06-20 18:40 ` Leon Romanovsky
[not found] ` <20170620184046.GW17846-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-06-21 14:46 ` Chuck Lever
[not found] ` <B34E95B2-A7D9-4725-B7C2-3DA4DACD29B7-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-06-21 14:56 ` Leon Romanovsky
2017-06-27 9:24 ` Sagi Grimberg
[not found] ` <16d52534-5564-8137-a8b3-6c66df6bb508-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-06-28 9:56 ` Leon Romanovsky
[not found] ` <20170628095640.GB1248-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-06-28 10:15 ` Sagi Grimberg
[not found] ` <64eae30c-9490-b801-550d-d871473f0d29-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-06-28 13:45 ` Leon Romanovsky
[not found] ` <20170628134528.GE1248-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-06-28 14:48 ` Sagi Grimberg
[not found] ` <275acec0-215e-8157-e6a0-4c0f48fe3d75-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-06-28 15:40 ` Leon Romanovsky
2017-06-28 14:49 ` Chuck Lever
[not found] ` <373E6A00-8505-468C-A974-DCDAC15A3B7B-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-06-28 15:41 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516054256.GA4013@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.