From: Vinod Koul <vinod.koul@intel.com>
To: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
Pardha Saradhi K <pardha.saradhi.kesapragada@intel.com>,
lgirdwood@gmail.com, patches.audio@intel.com, broonie@kernel.org
Subject: Re: [PATCH 1/3] ASoC: Intel: Skylake: Fix IPC rx_list corruption
Date: Tue, 16 May 2017 11:41:11 +0530 [thread overview]
Message-ID: <20170516061111.GI15061@localhost> (raw)
In-Reply-To: <1494857671-19257-1-git-send-email-subhransu.s.prusty@intel.com>
On Mon, May 15, 2017 at 07:44:29PM +0530, Subhransu S. Prusty wrote:
> From: Pardha Saradhi K <pardha.saradhi.kesapragada@intel.com>
>
> In SKL+ platforms, all IPC commands are serialised, i.e. the driver sends
> a new IPC to DSP, only after receiving a reply from the firmware for the
> current IPC.
>
> Hence it seems apparent that there is only a single modifier of the IPC RX
> List. However, during an IPC timeout case in a multithreaded environment,
> there is a possibility of the list element being deleted two times if not
> properly protected.
>
> So, use spin lock save/restore to prevent rx_list corruption.
Looks good, all three:
Acked-by: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
next prev parent reply other threads:[~2017-05-16 6:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 14:14 [PATCH 1/3] ASoC: Intel: Skylake: Fix IPC rx_list corruption Subhransu S. Prusty
2017-05-15 14:14 ` [PATCH 2/3] ASoC: Intel: Skylake: Fix to parse consecutive string tkns in manifest Subhransu S. Prusty
2017-05-24 17:41 ` Applied "ASoC: Intel: Skylake: Fix to parse consecutive string tkns in manifest" to the asoc tree Mark Brown
2017-05-15 14:14 ` [PATCH 3/3] ASoC: Intel: Skylake: Support for multiple data blocks Subhransu S. Prusty
2017-05-24 17:41 ` Applied "ASoC: Intel: Skylake: Support for multiple data blocks" to the asoc tree Mark Brown
2017-05-16 6:11 ` Vinod Koul [this message]
2017-05-24 17:41 ` Applied "ASoC: Intel: Skylake: Fix IPC rx_list corruption" " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516061111.GI15061@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=pardha.saradhi.kesapragada@intel.com \
--cc=patches.audio@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.