All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: davem@davemloft.net
Cc: ubraun@linux.vnet.ibm.com, netdev@vger.kernel.org,
	iinux-rdma@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: [PATCH net v1] net/smc: Add warning about remote memory exposure
Date: Tue, 16 May 2017 09:51:38 +0300	[thread overview]
Message-ID: <20170516065138.24789-1-leon@kernel.org> (raw)

From: Christoph Hellwig <hch@lst.de>

The driver explicitly bypasses APIs to register all memory once a
connection is made, and thus allows remote access to memory.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
---
Dave,
Can you please forward this patch to stable?
Thanks
---
 Changes from v0:
  * Remove BROKEN Kconfig option as a followup of this discussion
    https://patchwork.ozlabs.org/patch/760454/
  * Refine commit message
---
 net/smc/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/net/smc/Kconfig b/net/smc/Kconfig
index c717ef0896aa..33954852f3f8 100644
--- a/net/smc/Kconfig
+++ b/net/smc/Kconfig
@@ -8,6 +8,10 @@ config SMC
 	  The Linux implementation of the SMC-R solution is designed as
 	  a separate socket family SMC.

+	  Warning: SMC will expose all memory for remote reads and writes
+	  once a connection is established.  Don't enable this option except
+	  for tightly controlled lab environment.
+
 	  Select this option if you want to run SMC socket applications

 config SMC_DIAG

             reply	other threads:[~2017-05-16  6:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-16  6:51 Leon Romanovsky [this message]
     [not found] ` <20170516065138.24789-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-05-16  7:03   ` [PATCH net v1] net/smc: Add warning about remote memory exposure Leon Romanovsky
2017-05-16 15:04 ` Ursula Braun
2017-05-16 18:53 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170516065138.24789-1-leon@kernel.org \
    --to=leon@kernel.org \
    --cc=davem@davemloft.net \
    --cc=hch@lst.de \
    --cc=iinux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ubraun@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.