From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH] drivers/staging/ccree: Fixing coding guideline errors Date: Tue, 16 May 2017 10:16:29 +0200 Message-ID: <20170516081629.GA5631@kroah.com> References: <1494921952-8384-1-git-send-email-pushkar.iit@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org To: Pushkar Jambhlekar Return-path: Content-Disposition: inline In-Reply-To: <1494921952-8384-1-git-send-email-pushkar.iit@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: linux-crypto.vger.kernel.org On Tue, May 16, 2017 at 01:35:52PM +0530, Pushkar Jambhlekar wrote: > Fixing coding guideline errors reported by 'checkpatch.pl' That is very "vague", you are going to have to be specific here. Also remember you can only do "one type of thing" per patch, and no, "fix all warnings" is not one type of thing :) thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752034AbdEPIQl (ORCPT ); Tue, 16 May 2017 04:16:41 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53884 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751425AbdEPIQj (ORCPT ); Tue, 16 May 2017 04:16:39 -0400 Date: Tue, 16 May 2017 10:16:29 +0200 From: Greg Kroah-Hartman To: Pushkar Jambhlekar Cc: Gilad Ben-Yossef , devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/staging/ccree: Fixing coding guideline errors Message-ID: <20170516081629.GA5631@kroah.com> References: <1494921952-8384-1-git-send-email-pushkar.iit@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494921952-8384-1-git-send-email-pushkar.iit@gmail.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 16, 2017 at 01:35:52PM +0530, Pushkar Jambhlekar wrote: > Fixing coding guideline errors reported by 'checkpatch.pl' That is very "vague", you are going to have to be specific here. Also remember you can only do "one type of thing" per patch, and no, "fix all warnings" is not one type of thing :) thanks, greg k-h