All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin O'Connor <kevin@koconnor.net>
To: "Xu, Anthony" <anthony.xu@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] target/i386: enable A20 automatically in system management mode
Date: Tue, 16 May 2017 12:24:42 -0400	[thread overview]
Message-ID: <20170516162442.GA4177@morn.lan> (raw)
In-Reply-To: <4712D8F4B26E034E80552F30A67BE0B1AB6DEF@ORSMSX112.amr.corp.intel.com>

On Sat, May 13, 2017 at 01:24:30AM +0000, Xu, Anthony wrote:
> I think it is related to accel and platform, the result I gave before is for q35 tcg,
> 
> With the above change,   I got below data
> 
> Platform	accel		count of restoring A20 to 0
> Q35		kvm		96
> Q35		tcg		271
> PC		kvm		3
> PC		tcg		3

Okay, thanks.  I think the number of a20 switches is due to
differences in option rom execution interacting with the fact that
some mode switches were occurring before SeaBIOS set
call16_override().

> But I still see a lot of PORT_A20 accesses in QEMU as I expected

Yes, but it should be possible to significantly reduce the number of
outb() calls by limiting them to when A20 changes.  This should also
be useful to reduce the number of outb() calls needed to disable NMIs.
I sent a patch series to the seabios mailing list to demonstrate the
idea.

-Kevin

  reply	other threads:[~2017-05-16 16:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-11 11:35 [Qemu-devel] [PATCH] target/i386: enable A20 automatically in system management mode Paolo Bonzini
2017-05-11 11:41 ` no-reply
2017-05-11 11:58 ` no-reply
2017-05-11 14:53 ` Kevin O'Connor
2017-05-11 15:32   ` Paolo Bonzini
2017-05-11 16:34     ` Kevin O'Connor
2017-05-11 23:55       ` Xu, Anthony
2017-05-12 12:16         ` Paolo Bonzini
2017-05-12 18:55           ` Xu, Anthony
2017-05-12 19:16             ` Paolo Bonzini
2017-05-12 19:38               ` Kevin O'Connor
2017-05-12 23:19                 ` Xu, Anthony
2017-05-13  0:01                   ` Kevin O'Connor
2017-05-13  1:24                     ` Xu, Anthony
2017-05-16 16:24                       ` Kevin O'Connor [this message]
2017-05-16 20:00                         ` Xu, Anthony
2017-05-16 21:42                           ` Kevin O'Connor
2017-05-16 22:39                             ` Xu, Anthony
2017-05-17  8:18                             ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170516162442.GA4177@morn.lan \
    --to=kevin@koconnor.net \
    --cc=anthony.xu@intel.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.