Re: [PATCH 1/2] libndp: switch to github uri. libndp.org is unstable

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2107 bytes --]

On Wed, May 17, 2017 at 08:35:23AM +0200, Anders Darander wrote:
> Hi,
> 
> * Gianfranco Costamagna <costamagna.gianfranco@gmail.com> [170516 13:15]:
> 
> First, the subject should have included [PATCH v2 1/2] instead of just
> [PATCH 1/2], as this really is the 2nd version. (This applies to the
> whole series).
> 
> > From: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>
> 
> > Signed-off-by: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com>
> > ---
> 
> Down here, a changelog for the changes between v1 and v2. (At least if
> they'r not covered by a cover letter).
> 
> >  meta-oe/recipes-connectivity/libndp/libndp_1.6.bb | 9 ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> > -SRC_URI = "http://libndp.org/files/${BPN}-${PV}.tar.gz \
> > +SRC_URI = "git://github.com/jpirko/libndp;branch=master;tag=v${PV} \
> 
> Pleasen, remove tag=v${PV} from the SRC_URI. Instead, add a SRVREV= the
> SHA1. If you use a tag, bitbake will reach out the git server upon each
> build to verify the SHA1 of the tag. That'll break off-line builds etc.

This is actually 6th version of this change I've seen on ML and one of
them (the one I've cherry-picked to master-next) already sets SRCREV
correctly (I made the same comment earlier).

https://patchwork.openembedded.org/project/oe/patches/?submitter=&state=*&q=libndp&archive=both&delegate=

> 
> Cheers,
> Anders
> 
> >             file://0001-include-sys-select.h-for-fd_-definitions.patch \
> >             "
> > -SRC_URI[md5sum] = "1e54d26bcb4a4110bc3f90c5dd04f1a7"
> > -SRC_URI[sha256sum] = "0c7dfa84e013bd5e569ef2c6292a6f72cfaf14f4ff77a77425e52edc33ffac0e"
> > +
> > +S = "${WORKDIR}/git"
> > +
> 
> >  inherit autotools
> -- 
> Anders Darander, Senior System Architect
> ChargeStorm AB / eStorm AB
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]