From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Subject: [PATCH] scsi: remove useless variable assignment
Date: Wed, 17 May 2017 19:30:43 -0500 [thread overview]
Message-ID: <20170518003043.GA5664@embeddedgus> (raw)
Remove this assignment once the value stored in variable _k_ is
overwritten after a few lines.
Addresses-Coverity-ID: 1226927
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/scsi/qlogicfas408.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/qlogicfas408.c b/drivers/scsi/qlogicfas408.c
index c3a9151..269440a 100644
--- a/drivers/scsi/qlogicfas408.c
+++ b/drivers/scsi/qlogicfas408.c
@@ -329,7 +329,6 @@ static unsigned int ql_pcmd(struct scsi_cmnd *cmd)
*/
if ((k = ql_wai(priv)))
return (k << 16);
- k = inb(qbase + 5); /* should be 0x10, bus service */
}
/*
--
2.5.0
next reply other threads:[~2017-05-18 0:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 0:30 Gustavo A. R. Silva [this message]
2017-05-18 4:39 ` [PATCH] scsi: remove useless variable assignment James Bottomley
2017-05-18 17:41 ` Gustavo A. R. Silva
2017-06-10 21:12 ` James Bottomley
-- strict thread matches above, loose matches on Subject: below --
2017-05-18 1:00 Gustavo A. R. Silva
2017-06-07 20:27 Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518003043.GA5664@embeddedgus \
--to=garsilva@embeddedor.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.