From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6068521A16EFD for ; Thu, 18 May 2017 00:13:55 -0700 (PDT) Date: Thu, 18 May 2017 09:13:52 +0200 From: Christoph Hellwig Subject: Re: [PATCH 03/23] uuid: remove uuid_be defintions from the uapi header Message-ID: <20170518071352.GA515@lst.de> References: <20170518062705.25902-1-hch@lst.de> <20170518062705.25902-4-hch@lst.de> <1495091565.31562.28.camel@perches.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1495091565.31562.28.camel@perches.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Joe Perches Cc: linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, Mimi Zohar , Amir Goldstein , linux-kernel@vger.kernel.org, Steven Whitehouse , David Howells , linux-fsdevel@vger.kernel.org, Andy Shevchenko , Shaohua Li , Christoph Hellwig List-ID: On Thu, May 18, 2017 at 12:12:45AM -0700, Joe Perches wrote: > On Thu, 2017-05-18 at 08:26 +0200, Christoph Hellwig wrote: > > We don't use uuid_be and the UUID_BE constants in any uapi headers, so make > > them private to the kernel. > > On the assumption that no user program uses them? > Is that a safe assumption? It's not a userspace ABI, so by defintion it does not break an existing user program. If someone was using it they should be using uuid_t from libuuid instead, as that gives them the routines to deal with it. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 03/23] uuid: remove uuid_be defintions from the uapi header Date: Thu, 18 May 2017 09:13:52 +0200 Message-ID: <20170518071352.GA515@lst.de> References: <20170518062705.25902-1-hch@lst.de> <20170518062705.25902-4-hch@lst.de> <1495091565.31562.28.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1495091565.31562.28.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Joe Perches Cc: linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, Mimi Zohar , Amir Goldstein , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Steven Whitehouse , David Howells , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andy Shevchenko , Shaohua Li , Christoph Hellwig List-Id: linux-raid.ids On Thu, May 18, 2017 at 12:12:45AM -0700, Joe Perches wrote: > On Thu, 2017-05-18 at 08:26 +0200, Christoph Hellwig wrote: > > We don't use uuid_be and the UUID_BE constants in any uapi headers, so make > > them private to the kernel. > > On the assumption that no user program uses them? > Is that a safe assumption? It's not a userspace ABI, so by defintion it does not break an existing user program. If someone was using it they should be using uuid_t from libuuid instead, as that gives them the routines to deal with it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:57072 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753792AbdERHNy (ORCPT ); Thu, 18 May 2017 03:13:54 -0400 Date: Thu, 18 May 2017 09:13:52 +0200 From: Christoph Hellwig Subject: Re: [PATCH 03/23] uuid: remove uuid_be defintions from the uapi header Message-ID: <20170518071352.GA515@lst.de> References: <20170518062705.25902-1-hch@lst.de> <20170518062705.25902-4-hch@lst.de> <1495091565.31562.28.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1495091565.31562.28.camel@perches.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Joe Perches Cc: Christoph Hellwig , Andy Shevchenko , Amir Goldstein , linux-fsdevel@vger.kernel.org, Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org On Thu, May 18, 2017 at 12:12:45AM -0700, Joe Perches wrote: > On Thu, 2017-05-18 at 08:26 +0200, Christoph Hellwig wrote: > > We don't use uuid_be and the UUID_BE constants in any uapi headers, so make > > them private to the kernel. > > On the assumption that no user program uses them? > Is that a safe assumption? It's not a userspace ABI, so by defintion it does not break an existing user program. If someone was using it they should be using uuid_t from libuuid instead, as that gives them the routines to deal with it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754342AbdERHN6 (ORCPT ); Thu, 18 May 2017 03:13:58 -0400 Received: from verein.lst.de ([213.95.11.211]:57072 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753792AbdERHNy (ORCPT ); Thu, 18 May 2017 03:13:54 -0400 Date: Thu, 18 May 2017 09:13:52 +0200 From: Christoph Hellwig To: Joe Perches Cc: Christoph Hellwig , Andy Shevchenko , Amir Goldstein , linux-fsdevel@vger.kernel.org, Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/23] uuid: remove uuid_be defintions from the uapi header Message-ID: <20170518071352.GA515@lst.de> References: <20170518062705.25902-1-hch@lst.de> <20170518062705.25902-4-hch@lst.de> <1495091565.31562.28.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1495091565.31562.28.camel@perches.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 18, 2017 at 12:12:45AM -0700, Joe Perches wrote: > On Thu, 2017-05-18 at 08:26 +0200, Christoph Hellwig wrote: > > We don't use uuid_be and the UUID_BE constants in any uapi headers, so make > > them private to the kernel. > > On the assumption that no user program uses them? > Is that a safe assumption? It's not a userspace ABI, so by defintion it does not break an existing user program. If someone was using it they should be using uuid_t from libuuid instead, as that gives them the routines to deal with it.