From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [Intel-gfx] [PATCH v2 2/3] drm: Create a format/modifier blob Date: Thu, 18 May 2017 12:02:13 +0300 Message-ID: <20170518090213.GX12629@intel.com> References: <20170516213126.8269-1-ben@bwidawsk.net> <20170516213126.8269-2-ben@bwidawsk.net> <20170518004618.GC2334@mail.bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170518004618.GC2334@mail.bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ben Widawsky Cc: "Kristian H . Kristensen" , Intel GFX , Emil Velikov , Daniel Stone , DRI Development List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBNYXkgMTcsIDIwMTcgYXQgMDU6NDY6MThQTSAtMDcwMCwgQmVuIFdpZGF3c2t5IHdy b3RlOgo+IE9uIDE3LTA1LTE3IDAxOjA2OjE2LCBFbWlsIFZlbGlrb3Ygd3JvdGU6Cj4gPkhpIEJl biwKPiA+Cj4gPk9uIDE2IE1heSAyMDE3IGF0IDIyOjMxLCBCZW4gV2lkYXdza3kgPGJlbkBid2lk YXdzay5uZXQ+IHdyb3RlOgo+ID4+IFVwZGF0ZWQgYmxvYiBsYXlvdXQgKFJvYiwgRGFuaWVsLCBL cmlzdGlhbiwgeGVycGkpCj4gPj4KPiA+PiB2MjoKPiA+PiAqIFJlbW92ZWQgX19wYWNrZWQsIGFu ZCBhbGlnbm1lbnQgKC4rKQo+ID4+ICogRml4IGluZGVudCBpbiBkcm1fZm9ybWF0X21vZGlmaWVy IGZpZWxkcyAoTGl2aXUpCj4gPj4gKiBSZW1vdmUgZHVwbGljYXRlZCBtb2RpZmllciA+IDY0IGNo ZWNrIChMaXZpdSkKPiA+PiAqIENoYW5nZSBjb21tZW50IGFib3V0IG1vZGlmaWVyIChMaXZpdSkK PiA+PiAqIFJlbW92ZSBhcmd1bWVudHMgdG8gYmxvYiBjcmVhdGlvbiwgdXNlIHBsYW5lIGluc3Rl YWQgKExpdml1KQo+ID4+ICogRml4IGRhdGEgdHlwZXMgKEJlbikKPiA+PiAqIE1ha2UgdGhlIGJs b2IgcGFydCBvZiB1YXBpIChEYW5pZWwpCj4gPj4KPiA+PiBDYzogUm9iIENsYXJrIDxyb2JkY2xh cmtAZ21haWwuY29tPgo+ID4+IENjOiBEYW5pZWwgU3RvbmUgPGRhbmllbHNAY29sbGFib3JhLmNv bT4KPiA+PiBDYzogS3Jpc3RpYW4gSC4gS3Jpc3RlbnNlbiA8aG9lZ3NiZXJnQGdtYWlsLmNvbT4K PiA+PiBDYzogTGl2aXUgRHVkYXUgPGxpdml1QGR1ZGF1LmNvLnVrPgo+ID4+IFNpZ25lZC1vZmYt Ynk6IEJlbiBXaWRhd3NreSA8YmVuQGJ3aWRhd3NrLm5ldD4KPiA+PiBSZXZpZXdlZC1ieTogRGFu aWVsIFN0b25lIDxkYW5pZWxzQGNvbGxhYm9yYS5jb20+Cj4gPgo+ID5JIHRoaW5rIHRoaXMgaXMg YWxtb3N0IHBlcmZlY3QsIGJhcnJpbmcgdGhlIFVBUEkgbml0cGljay4KPiA+VGhlIHJlc3QgaXMg c29tZXdoYXQgb2YgYSBiaWtlc2hlZGRpbmcuCj4gPgo+ID5XaXRoIHRoZSBVQVBJIHJlc29sdmVk LCByZWdhcmRsZXNzIG9mIHRoZSByZXN0Cj4gPlJldmlld2VkLWJ5OiBFbWlsIFZlbGlrb3YgPGVt aWwubC52ZWxpa292QGdtYWlsLmNvbT4KPiA+Cj4gPgo+ID4+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fcGxhbmUuYwo+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fcGxhbmUuYwo+ID4K PiA+PiArc3RhdGljIGludCBjcmVhdGVfaW5fZm9ybWF0X2Jsb2Ioc3RydWN0IGRybV9kZXZpY2Ug KmRldiwgc3RydWN0IGRybV9wbGFuZSAqcGxhbmUpCj4gPj4gK3sKPiA+PiArICAgICAgIGNvbnN0 IHN0cnVjdCBkcm1fbW9kZV9jb25maWcgKmNvbmZpZyA9ICZkZXYtPm1vZGVfY29uZmlnOwo+ID4+ ICsgICAgICAgY29uc3QgdWludDY0X3QgKnRlbXBfbW9kaWZpZXJzID0gcGxhbmUtPm1vZGlmaWVy czsKPiA+PiArICAgICAgIHVuc2lnbmVkIGludCBmb3JtYXRfbW9kaWZpZXJfY291bnQgPSAwOwo+ ID4+ICsgICAgICAgc3RydWN0IGRybV9wcm9wZXJ0eV9ibG9iICpibG9iID0gTlVMTDsKPiA+PiAr ICAgICAgIHN0cnVjdCBkcm1fZm9ybWF0X21vZGlmaWVyICptb2Q7Cj4gPj4gKyAgICAgICBzaXpl X3QgYmxvYl9zaXplID0gMCwgZm9ybWF0c19zaXplLCBtb2RpZmllcnNfc2l6ZTsKPiA+VGhlcmUn cyBubyBuZWVkIHRvIGluaXRpYWxpemUgYmxvYiBhbmQgYmxvYl9zaXplIGhlcmUuCj4gPgo+ID4+ ICsgICAgICAgc3RydWN0IGRybV9mb3JtYXRfbW9kaWZpZXJfYmxvYiAqYmxvYl9kYXRhOwo+ID4+ ICsgICAgICAgaW50IGksIGosIHJldCA9IDA7Cj4gPk1ha2UgaSBhbmQgaiB1bnNpZ25lZCB0byBt YXRjaCBmb3JtYXRfbW9kaWZpZXJfY291bnQgYW5kCj4gPnBsYW5lLT5mb3JtYXRfY291bnQgcmVz cGVjdGl2ZWx5Lgo+ID5UaGVuIGV4cGFuZCByZXQgaW4gdGhlIG9ubHkgcGxhY2Ugd2hlcmUgaXQn cyB1c2VkPwo+ID4KPiAKPiBPaC4gcmV0IGhhcyBsb3N0IGl0J3MgdXRpbGl0eSBvdmVyIHRoZSBp dGVyYXRpb25zIG9mIHRoaXMgcGF0Y2guIE1ha2UgaSBhbmQgago+IHVuc2lnbmVkIGFuZCBkcm9w cGVkIHJldC4KClVuc2lnbmVkIGxvb3AgaXRlcmF0b3JzIHdpbGwgbGlrZWx5IGJpdGUgc29tZW9u ZSBzb21lIGRheSwgZXNwZWNpYWxseQppZiB0aGV5J3JlIGNhbGxlZCBzb21ldGhpbmcgbGlrZSAn aScsICdqJywgZXRjLiBJTU8gaXQncyBiZXN0IHRvIGtlZXAKdGhlbSBzaWduZWQuCgo+IAo+ID4+ ICsKPiA+PiArICAgICAgIGlmIChwbGFuZS0+bW9kaWZpZXJzKQo+ID4+ICsgICAgICAgICAgICAg ICB3aGlsZSAoKnRlbXBfbW9kaWZpZXJzKysgIT0gRFJNX0ZPUk1BVF9NT0RfSU5WQUxJRCkKPiA+ PiArICAgICAgICAgICAgICAgICAgICAgICBmb3JtYXRfbW9kaWZpZXJfY291bnQrKzsKPiA+PiAr Cj4gPj4gKyAgICAgICBmb3JtYXRzX3NpemUgPSBzaXplb2YoKnBsYW5lLT5mb3JtYXRfdHlwZXMp ICogcGxhbmUtPmZvcm1hdF9jb3VudDsKPiA+PiArICAgICAgIGlmIChXQVJOX09OKCFmb3JtYXRz X3NpemUpKSB7Cj4gPj4gKyAgICAgICAgICAgICAgIC8qIDAgZm9ybWF0cyBhcmUgbmV2ZXIgZXhw ZWN0ZWQgKi8KPiA+PiArICAgICAgICAgICAgICAgcmV0dXJuIDA7Cj4gPj4gKyAgICAgICB9Cj4g Pj4gKwo+ID4+ICsgICAgICAgbW9kaWZpZXJzX3NpemUgPQo+ID4+ICsgICAgICAgICAgICAgICBz aXplb2Yoc3RydWN0IGRybV9mb3JtYXRfbW9kaWZpZXIpICogZm9ybWF0X21vZGlmaWVyX2NvdW50 Owo+ID4+ICsKPiA+PiArICAgICAgIGJsb2Jfc2l6ZSA9IHNpemVvZihzdHJ1Y3QgZHJtX2Zvcm1h dF9tb2RpZmllcl9ibG9iKTsKPiA+PiArICAgICAgIGJsb2Jfc2l6ZSArPSBBTElHTihmb3JtYXRz X3NpemUsIDgpOwo+ID5Xb3J0aCBoYXZpbmcgdGhlICJNb2RpZmllcnMgb2Zmc2V0IGlzIGEgcG9p bnRlci4uLiIgY29tbWVudCBtb3ZlZC9jb3BpZWQgaGVyZT8KPiA+Cj4gCj4gWWVzIGl0IGlzLgo+ IAo+ID4+ICsgICAgICAgYmxvYl9zaXplICs9IG1vZGlmaWVyc19zaXplOwo+ID4+ICsKPiA+PiAr ICAgICAgIGJsb2IgPSBkcm1fcHJvcGVydHlfY3JlYXRlX2Jsb2IoZGV2LCBibG9iX3NpemUsIE5V TEwpOwo+ID4+ICsgICAgICAgaWYgKElTX0VSUihibG9iKSkKPiA+PiArICAgICAgICAgICAgICAg cmV0dXJuIC0xOwo+ID4+ICsKPiA+TWF5YmUgcHJvcGFnYXRlIHRoZSBleGFjdCBlcnJvci4uLiBI bW0gd2UgZG9uJ3Qgc2VlbSB0byBjaGVjayBpZgo+ID5jcmVhdGVfaW5fZm9ybWF0X2Jsb2IgZmFp bHMgZWl0aGVyIHNvIHBlcmhhcHMgaXQncyBub3Qgd29ydGggaXQuCj4gPgo+ID4KPiAKPiBJbiB0 aGlzIGNhc2UgaXQncyBhbG1vc3QgZGVmaW5pdGVseSBFTk9NRU0uIEFsbCB2YWx1ZXMgc2hvdWxk IGJlIHZlcmlmaWVkIC0gSQo+IHRoaW5rIHRoZSBvdGhlciBlcnJvcnMgYXJlIHRoZXJlIGZvciB3 aGVuIHVzZXJzcGFjZSBpcyB1dGlsaXppbmcgYmxvYiBjcmVhdGlvbi4KPiAKPiBTbyBJJ2xsIGp1 c3QgbGVhdmUgaXQuCj4gCj4gPj4gLS0tIGEvaW5jbHVkZS91YXBpL2RybS9kcm1fbW9kZS5oCj4g Pj4gKysrIGIvaW5jbHVkZS91YXBpL2RybS9kcm1fbW9kZS5oCj4gPj4gQEAgLTY2NSw2ICs2NjUs NTYgQEAgc3RydWN0IGRybV9tb2RlX2F0b21pYyB7Cj4gPj4gICAgICAgICBfX3U2NCB1c2VyX2Rh dGE7Cj4gPj4gIH07Cj4gPj4KPiA+PiArc3RydWN0IGRybV9mb3JtYXRfbW9kaWZpZXJfYmxvYiB7 Cj4gPj4gKyNkZWZpbmUgRk9STUFUX0JMT0JfQ1VSUkVOVCAxCj4gPj4gKyAgICAgICAvKiBWZXJz aW9uIG9mIHRoaXMgYmxvYiBmb3JtYXQgKi8KPiA+PiArICAgICAgIHUzMiB2ZXJzaW9uOwo+ID4+ ICsKPiA+PiArICAgICAgIC8qIEZsYWdzICovCj4gPj4gKyAgICAgICB1MzIgZmxhZ3M7Cj4gPj4g Kwo+ID4+ICsgICAgICAgLyogTnVtYmVyIG9mIGZvdXJjYyBmb3JtYXRzIHN1cHBvcnRlZCAqLwo+ ID4+ICsgICAgICAgdTMyIGNvdW50X2Zvcm1hdHM7Cj4gPj4gKwo+ID4+ICsgICAgICAgLyogV2hl cmUgaW4gdGhpcyBibG9iIHRoZSBmb3JtYXRzIGV4aXN0IChpbiBieXRlcykgKi8KPiA+PiArICAg ICAgIHUzMiBmb3JtYXRzX29mZnNldDsKPiA+PiArCj4gPj4gKyAgICAgICAvKiBOdW1iZXIgb2Yg ZHJtX2Zvcm1hdF9tb2RpZmllcnMgKi8KPiA+PiArICAgICAgIHUzMiBjb3VudF9tb2RpZmllcnM7 Cj4gPj4gKwo+ID4+ICsgICAgICAgLyogV2hlcmUgaW4gdGhpcyBibG9iIHRoZSBtb2RpZmllcnMg ZXhpc3QgKGluIGJ5dGVzKSAqLwo+ID4+ICsgICAgICAgdTMyIG1vZGlmaWVyc19vZmZzZXQ7Cj4g Pj4gKwo+ID4+ICsgICAgICAgLyogdTMyIGZvcm1hdHNbXSAqLwo+ID4+ICsgICAgICAgLyogc3Ry dWN0IGRybV9mb3JtYXRfbW9kaWZpZXIgbW9kaWZpZXJzW10gKi8KPiA+PiArfTsKPiA+PiArCj4g Pj4gK3N0cnVjdCBkcm1fZm9ybWF0X21vZGlmaWVyIHsKPiA+PiArICAgICAgIC8qIEJpdG1hc2sg b2YgZm9ybWF0cyBpbiBnZXRfcGxhbmUgZm9ybWF0IGxpc3QgdGhpcyBpbmZvIGFwcGxpZXMgdG8u IFRoZQo+ID4+ICsgICAgICAgICogb2Zmc2V0IGFsbG93cyBhIHNsaWRpbmcgd2luZG93IG9mIHdo aWNoIDY0IGZvcm1hdHMgKGJpdHMpLgo+ID4+ICsgICAgICAgICoKPiA+PiArICAgICAgICAqIFNv bWUgZXhhbXBsZXM6Cj4gPj4gKyAgICAgICAgKiBJbiB0b2RheSdzIHdvcmxkIHdpdGggPCA2NSBm b3JtYXRzLCBhbmQgZm9ybWF0cyAwLCBhbmQgMiBhcmUKPiA+PiArICAgICAgICAqIHN1cHBvcnRl ZAo+ID4+ICsgICAgICAgICogMHgwMDAwMDAwMDAwMDAwMDA1Cj4gPj4gKyAgICAgICAgKiAgICAg ICAgICAgICAgICBeLW9mZnNldCA9IDAsIGZvcm1hdHMgPSA1Cj4gPj4gKyAgICAgICAgKgo+ID4+ ICsgICAgICAgICogSWYgdGhlIG51bWJlciBmb3JtYXRzIGdyZXcgdG8gMTI4LCBhbmQgZm9ybWF0 cyA5OC0xMDIgYXJlCj4gPj4gKyAgICAgICAgKiBzdXBwb3J0ZWQgd2l0aCB0aGUgbW9kaWZpZXI6 Cj4gRz4+ICsgICAgICAgICoKPiA+PiArICAgICAgICAqIDB4MDAwMDAwM2MwMDAwMDAwMCAwMDAw MDAwMDAwMDAwMDAwCj4gPj4gKyAgICAgICAgKiAgICAgICAgICAgICAgICBeCj4gPj4gKyAgICAg ICAgKiAgICAgICAgICAgICAgICB8X19vZmZzZXQgPSA2NCwgZm9ybWF0cyA9IDB4M2MwMDAwMDAw MAo+ID4+ICsgICAgICAgICoKPiA+PiArICAgICAgICAqLwo+ID4+ICsgICAgICAgX191NjQgZm9y bWF0czsKPiA+PiArICAgICAgIF9fdTMyIG9mZnNldDsKPiA+PiArICAgICAgIF9fdTMyIHBhZDsK PiA+PiArCj4gPj4gKyAgICAgICAvKiBUaGUgbW9kaWZpZXIgdGhhdCBhcHBsaWVzIHRvIHRoZSA+ Z2V0X3BsYW5lIGZvcm1hdCBsaXN0IGJpdG1hc2suICovCj4gPj4gKyAgICAgICBfX3U2NCBtb2Rp ZmllcjsKPiA+UGxlYXNlIGRyb3AgdGhlIGxlYWRpbmcgX18gZnJvbSB0aGUgdHlwZSBuYW1lcyBp biBVQVBJIGhlYWRlcnMuCj4gPgo+IAo+IE1hbnkgb3RoZXIgc3RydWN0dXJlcyBoYXZlIHRoZSBf XywgY2FuIHlvdSBleHBsYWluIHdoeSBwbGVhc2UgKHRoaXMgaGFzIHByb2JhYmx5Cj4gYmVlbiBi ZWF0ZW4gdG8gZGVhdGggYWxyZWFkeTsgYnV0IEkgZG9uJ3Qga25vdyk/CgpfXyBpcyB0aGUgcmln dGggY2hvaWNlIGZvciB1YXBpIGhlYWRlcnMsIHVubGVzcyB0aGUgcnVsZXMgaGF2ZSBjaGFuZ2Vk CnJlY2VudGx5LgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==