From: Greg KH <greg@kroah.com>
To: Matej Dujava <mdujava@kocurkovo.cz>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/7] staging: sm750fb: unifying macro usage and definitions
Date: Thu, 18 May 2017 15:56:26 +0200 [thread overview]
Message-ID: <20170518135626.GC6772@kroah.com> (raw)
In-Reply-To: <1494926423-6476-3-git-send-email-mdujava@kocurkovo.cz>
On Tue, May 16, 2017 at 11:20:18AM +0200, Matej Dujava wrote:
> This patch adds tabs into macro definitions so all rhs are on same column.
> Move MHz macro from ddk_chip.c to ddk_chip.h.
>
> Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz>
> ---
> drivers/staging/sm750fb/ddk750_chip.c | 18 ++++----
> drivers/staging/sm750fb/ddk750_chip.h | 5 +-
> drivers/staging/sm750fb/ddk750_display.h | 78 ++++++++++++++++----------------
> drivers/staging/sm750fb/ddk750_hwi2c.c | 4 +-
> drivers/staging/sm750fb/sm750.h | 6 +--
> 5 files changed, 55 insertions(+), 56 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index 944dd25..64d0a53 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -5,8 +5,6 @@
> #include "ddk750_chip.h"
> #include "ddk750_power.h"
>
> -#define MHz(x) ((x) * 1000000)
> -
> static logical_chip_type_t chip;
>
> logical_chip_type_t sm750_get_chip_type(void)
> @@ -36,7 +34,7 @@ static unsigned int get_mxclk_freq(void)
> unsigned int M, N, OD, POD;
>
> if (sm750_get_chip_type() == SM750LE)
> - return MHz(130);
> + return MHZ(130);
But MHz makes more sense, don't you think so?
Please leave that as-is.
thanks,
greg k-h
next prev parent reply other threads:[~2017-05-18 13:56 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-13 22:42 [PATCH 0/9] staging: sm750fb: cleaning code Matej Dujava
2017-05-13 22:42 ` [PATCH 1/9] staging: sm750fb: fix length of lines Matej Dujava
2017-05-15 8:32 ` Dan Carpenter
2017-05-13 22:42 ` [PATCH 2/9] staging: sm750fb: unifying macro definitions Matej Dujava
2017-05-13 22:42 ` [PATCH 3/9] staging: sm750fb: reordering of " Matej Dujava
2017-05-15 10:20 ` Greg KH
2017-05-13 22:42 ` [PATCH 4/9] staging: sm750fb: removing unnecessary binary operations Matej Dujava
2017-05-15 10:21 ` Greg KH
2017-05-13 22:42 ` [PATCH 5/9] staging: sm750fb: Remove typedef from "typedef enum _logical_chip_type_t" Matej Dujava
2017-05-13 22:42 ` [PATCH 6/9] staging: sm750fb: Remove typedef from "typedef enum _clock_type_t" Matej Dujava
2017-05-13 22:42 ` [PATCH 7/9] staging: sm750fb: Remove typedef from "typedef enum _disp_output_t" Matej Dujava
2017-05-13 22:42 ` [PATCH 8/9] staging: sm750fb: Remove typedef from "typedef enum _DPMS_t" Matej Dujava
2017-05-13 22:42 ` [PATCH 9/9] staging: sm750fb: Remove typedef from "typedef enum _sii164_hot_plug_mode_t" Matej Dujava
2017-05-15 10:22 ` [PATCH 0/9] staging: sm750fb: cleaning code Greg KH
2017-05-15 21:54 ` [PATCH v2 0/7] " Matej Dujava
2017-05-16 9:20 ` [PATCH v3 " Matej Dujava
2017-05-16 11:34 ` Greg KH
2017-05-16 9:20 ` [PATCH v3 1/7] staging: sm750fb: fix length of lines, function calls and declaration Matej Dujava
2017-05-16 9:20 ` [PATCH v3 2/7] staging: sm750fb: unifying macro usage and definitions Matej Dujava
2017-05-18 13:56 ` Greg KH [this message]
2017-06-13 7:40 ` Matej Dujava
2017-05-16 9:20 ` [PATCH v3 3/7] staging: sm750fb: Remove typedef from "typedef enum _logical_chip_type_t" Matej Dujava
2017-05-16 9:20 ` [PATCH v3 4/7] staging: sm750fb: Remove typedef from "typedef enum _clock_type_t" Matej Dujava
2017-05-16 9:20 ` [PATCH v3 5/7] staging: sm750fb: Remove typedef from "typedef enum _disp_output_t" Matej Dujava
2017-05-16 9:20 ` [PATCH v3 6/7] staging: sm750fb: Remove typedef from "typedef enum _DPMS_t" Matej Dujava
2017-05-16 9:20 ` [PATCH v3 7/7] staging: sm750fb: Remove typedef from "typedef enum _sii164_hot_plug_mode_t" Matej Dujava
2017-05-15 21:54 ` [PATCH v2 1/7] staging: sm750fb: fix length of lines, function calls and declaration Matej Dujava
2017-05-15 21:54 ` [PATCH v2 2/7] staging: sm750fb: unifying macro usage and definitions Matej Dujava
2017-05-15 21:54 ` [PATCH v2 3/7] staging: sm750fb: Remove typedef from "typedef enum _logical_chip_type_t" Matej Dujava
2017-05-15 21:54 ` [PATCH v2 4/7] staging: sm750fb: Remove typedef from "typedef enum _clock_type_t" Matej Dujava
2017-05-15 21:54 ` [PATCH v2 5/7] staging: sm750fb: Remove typedef from "typedef enum _disp_output_t" Matej Dujava
2017-05-15 21:54 ` [PATCH v2 6/7] staging: sm750fb: Remove typedef from "typedef enum _DPMS_t" Matej Dujava
2017-05-15 21:54 ` [PATCH v2 7/7] staging: sm750fb: Remove typedef from "typedef enum _sii164_hot_plug_mode_t" Matej Dujava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518135626.GC6772@kroah.com \
--to=greg@kroah.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdujava@kocurkovo.cz \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.