From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Thu, 18 May 2017 16:13:30 +0100 Subject: [PATCH] arm64: cpufeature: check translation granule size based on kernel config In-Reply-To: <20170518142415.GA6425@leverpostej> References: <1495102873-10858-1-git-send-email-leo.yan@linaro.org> <20170518113627.GC25294@leoy-ThinkPad-T440> <20170518123840.GD21359@arm.com> <20170518124115.GC4957@leverpostej> <20170518130250.GE25294@leoy-ThinkPad-T440> <20170518142415.GA6425@leverpostej> Message-ID: <20170518151329.GF21359@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, May 18, 2017 at 03:24:15PM +0100, Mark Rutland wrote: > On Thu, May 18, 2017 at 09:02:50PM +0800, Leo Yan wrote: > > On Thu, May 18, 2017 at 01:41:15PM +0100, Mark Rutland wrote: > > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > > > index 94b8f7f..1f53314 100644 > > > --- a/arch/arm64/kernel/cpufeature.c > > > +++ b/arch/arm64/kernel/cpufeature.c > > > @@ -639,8 +639,8 @@ void update_cpu_features(int cpu, > > > * Mismatched CPU features are a recipe for disaster. Don't even > > > * pretend to support them. > > > */ > > > - WARN_TAINT_ONCE(taint, TAINT_CPU_OUT_OF_SPEC, > > > - "Unsupported CPU feature variation.\n"); > > > + pr_warn_once("Unsupported CPU feature variation detected.\n"); > > > + add_taint(TAINT_CPU_OUT_OF_SPEC); > > > > Should be add_taint(TAINT_CPU_OUT_OF_SPEC, LOCKDEP_STILL_OK)? > > Whoops; yes. I've picked this up with the fix above. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933684AbdERPNc (ORCPT ); Thu, 18 May 2017 11:13:32 -0400 Received: from foss.arm.com ([217.140.101.70]:33302 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932643AbdERPNa (ORCPT ); Thu, 18 May 2017 11:13:30 -0400 Date: Thu, 18 May 2017 16:13:30 +0100 From: Will Deacon To: Mark Rutland Cc: Leo Yan , Suzuki K Poulose , Catalin Marinas , Marc Zyngier , Ard Biesheuvel , James Morse , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Guodong Xu , Haojian Zhuang , Douglas Raillard Subject: Re: [PATCH] arm64: cpufeature: check translation granule size based on kernel config Message-ID: <20170518151329.GF21359@arm.com> References: <1495102873-10858-1-git-send-email-leo.yan@linaro.org> <20170518113627.GC25294@leoy-ThinkPad-T440> <20170518123840.GD21359@arm.com> <20170518124115.GC4957@leverpostej> <20170518130250.GE25294@leoy-ThinkPad-T440> <20170518142415.GA6425@leverpostej> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170518142415.GA6425@leverpostej> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 18, 2017 at 03:24:15PM +0100, Mark Rutland wrote: > On Thu, May 18, 2017 at 09:02:50PM +0800, Leo Yan wrote: > > On Thu, May 18, 2017 at 01:41:15PM +0100, Mark Rutland wrote: > > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > > > index 94b8f7f..1f53314 100644 > > > --- a/arch/arm64/kernel/cpufeature.c > > > +++ b/arch/arm64/kernel/cpufeature.c > > > @@ -639,8 +639,8 @@ void update_cpu_features(int cpu, > > > * Mismatched CPU features are a recipe for disaster. Don't even > > > * pretend to support them. > > > */ > > > - WARN_TAINT_ONCE(taint, TAINT_CPU_OUT_OF_SPEC, > > > - "Unsupported CPU feature variation.\n"); > > > + pr_warn_once("Unsupported CPU feature variation detected.\n"); > > > + add_taint(TAINT_CPU_OUT_OF_SPEC); > > > > Should be add_taint(TAINT_CPU_OUT_OF_SPEC, LOCKDEP_STILL_OK)? > > Whoops; yes. I've picked this up with the fix above. Will