From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
Cc: Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>,
Yoshihiro Shimoda
<yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH 2/4] usb: host: ohci-platform: Add support for omap3 and later
Date: Thu, 18 May 2017 08:46:39 -0700 [thread overview]
Message-ID: <20170518154639.GC10472@atomide.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1705181137310.1619-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
* Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org> [170518 08:41]:
> On Wed, 17 May 2017, Tony Lindgren wrote:
>
> > With the runtime PM implemented for ohci-platform driver, we can
> > now support omap3 and later OHCI by adding one device tree
> > property.
...
> > diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c
> > --- a/drivers/usb/host/ohci-platform.c
> > +++ b/drivers/usb/host/ohci-platform.c
> > @@ -170,6 +170,10 @@ static int ohci_platform_probe(struct platform_device *dev)
> > if (of_property_read_bool(dev->dev.of_node, "no-big-frame-no"))
> > ohci->flags |= OHCI_QUIRK_FRAME_NO;
> >
> > + if (of_property_read_bool(dev->dev.of_node,
> > + "remote-wakeup-connected"))
> > + ohci->hc_control = OHCI_CTRL_RWC;
> > +
> > of_property_read_u32(dev->dev.of_node, "num-ports",
> > &ohci->num_ports);
> >
> > @@ -361,6 +365,7 @@ static int ohci_platform_resume(struct device *dev)
> > static const struct of_device_id ohci_platform_ids[] = {
> > { .compatible = "generic-ohci", },
> > { .compatible = "cavium,octeon-6335-ohci", },
> > + { .compatible = "ti,ohci-omap3", },
> > { }
> > };
> > MODULE_DEVICE_TABLE(of, ohci_platform_ids);
>
> Acked-by: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
FYI, this depends on the patch1/4 PM runtime issue getting sorted out
first as otherwise the USB controller is powered off on omaps. So let's
not apply this yet.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-05-18 15:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 22:59 [PATCH 0/4] Make ohci-platform usable for omap3/4/5 Tony Lindgren
[not found] ` <20170517225922.17723-1-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-05-17 22:59 ` [PATCH 1/4] usb: host: ohci-platform: Add basic runtime PM support Tony Lindgren
[not found] ` <20170517225922.17723-2-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-05-18 9:28 ` Roger Quadros
2017-05-18 15:25 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1705181114280.1619-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2017-05-18 15:52 ` Tony Lindgren
2017-05-18 17:21 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1705181313320.1619-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2017-05-19 17:52 ` Tony Lindgren
2017-05-17 22:59 ` [PATCH 2/4] usb: host: ohci-platform: Add support for omap3 and later Tony Lindgren
[not found] ` <20170517225922.17723-3-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-05-18 9:28 ` Roger Quadros
2017-05-18 15:38 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1705181137310.1619-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2017-05-18 15:46 ` Tony Lindgren [this message]
2017-05-17 22:59 ` [PATCH 3/4] usb: host: ohci-omap3: Print warning to get people to use ohci-platform Tony Lindgren
[not found] ` <20170517225922.17723-4-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-05-18 9:15 ` Sebastian Reichel
2017-05-18 14:08 ` Tony Lindgren
[not found] ` <20170518140857.GA10472-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-05-18 17:21 ` Sebastian Reichel
2017-05-19 17:39 ` Tony Lindgren
2017-05-18 15:47 ` Alan Stern
2017-05-17 22:59 ` [PATCH 4/4] ARM: dts: Add remote-wakeup-connected for omap OHCI Tony Lindgren
[not found] ` <20170517225922.17723-5-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-05-18 9:28 ` Roger Quadros
2017-05-18 15:49 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518154639.GC10472@atomide.com \
--to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=rogerq-l0cyMroinI0@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
--cc=yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.