All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Vladislav Yasevich <vyasevich@gmail.com>
Cc: netdev@vger.kernel.org, Vladislav Yasevich <vyasevic@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH net 3/3] virtio-net: enable TSO/checksum offloads for Q-in-Q vlans
Date: Thu, 18 May 2017 18:06:35 +0300	[thread overview]
Message-ID: <20170518180630-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1495114265-23368-4-git-send-email-vyasevic@redhat.com>

On Thu, May 18, 2017 at 09:31:05AM -0400, Vladislav Yasevich wrote:
> Since virtio does not provide it's own ndo_features_check handler,
> TSO, and now checksum offload, are disabled for stacked vlans.
> Re-enable the support and let the host take care of it.  This
> restores/improves Guest-to-Guest performance over Q-in-Q vlans.
> 
> CC: "Michael S. Tsirkin" <mst@redhat.com>
> CC: Jason Wang <jasowang@redhat.com>
> CC: virtualization@lists.linux-foundation.org
> Signed-off-by: Vladislav Yasevich <vyasevic@redhat.com>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  drivers/net/virtio_net.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 8324a5e..341fb96 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2028,6 +2028,7 @@ static const struct net_device_ops virtnet_netdev = {
>  	.ndo_poll_controller = virtnet_netpoll,
>  #endif
>  	.ndo_xdp		= virtnet_xdp,
> +	.ndo_features_check	= passthru_features_check,
>  };
>  
>  static void virtnet_config_changed_work(struct work_struct *work)
> -- 
> 2.7.4

  parent reply	other threads:[~2017-05-18 15:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18 13:31 [PATCH net 0/3] vlan: Offload fixes for Q-in-Q vlans Vladislav Yasevich
2017-05-18 13:31 ` [PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan Vladislav Yasevich
2017-05-19  1:04   ` Toshiaki Makita
2017-05-19  2:13   ` Toshiaki Makita
2017-05-19  7:09     ` Vlad Yasevich
2017-05-19  8:16       ` Toshiaki Makita
2017-05-19  9:53         ` Vlad Yasevich
2017-05-19 13:31           ` Toshiaki Makita
2017-05-22 23:59   ` David Miller
2017-05-23 12:59     ` Vlad Yasevich
2017-05-23 16:29     ` Alexander Duyck
2017-05-18 13:31 ` [PATCH net 2/3] be2net: Fix offload features for Q-in-Q packets Vladislav Yasevich
2017-05-18 13:31 ` [PATCH net 3/3] virtio-net: enable TSO/checksum offloads for Q-in-Q vlans Vladislav Yasevich
2017-05-18 15:06   ` Michael S. Tsirkin
2017-05-18 15:06   ` Michael S. Tsirkin [this message]
2017-05-19 14:18   ` Jason Wang
2017-05-19 14:18   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170518180630-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=vyasevic@redhat.com \
    --cc=vyasevich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.