From: Peter Chen <hzpeterchen@gmail.com>
To: Michael Thalmeier <michael.thalmeier@hale.at>
Cc: Peter Chen <Peter.Chen@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<michael@thalmeier.at>
Subject: Re: [PATCH] usb: chipidea: debug: check before accessing ci_role
Date: Fri, 19 May 2017 08:57:18 +0800 [thread overview]
Message-ID: <20170519005718.GA7460@b29397-desktop> (raw)
In-Reply-To: <20170518141414.30798-1-michael.thalmeier@hale.at>
On Thu, May 18, 2017 at 04:14:14PM +0200, Michael Thalmeier wrote:
> ci_role BUGs when the role is >= CI_ROLE_END.
>
> Signed-off-by: Michael Thalmeier <michael.thalmeier@hale.at>
> ---
> drivers/usb/chipidea/debug.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c
> index 6d23eed..1c31e8a 100644
> --- a/drivers/usb/chipidea/debug.c
> +++ b/drivers/usb/chipidea/debug.c
> @@ -294,7 +294,8 @@ static int ci_role_show(struct seq_file *s, void *data)
> {
> struct ci_hdrc *ci = s->private;
>
> - seq_printf(s, "%s\n", ci_role(ci)->name);
> + if (ci->role != CI_ROLE_END)
> + seq_printf(s, "%s\n", ci_role(ci)->name);
>
> return 0;
> }
I will queue it, and cc stable
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2017-05-19 0:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 14:14 [PATCH] usb: chipidea: debug: check before accessing ci_role Michael Thalmeier
2017-05-19 0:57 ` Peter Chen [this message]
2017-05-19 1:15 ` Peter Chen
2017-05-19 8:14 ` Michael Thalmeier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519005718.GA7460@b29397-desktop \
--to=hzpeterchen@gmail.com \
--cc=Peter.Chen@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michael.thalmeier@hale.at \
--cc=michael@thalmeier.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.