From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 18 May 2017 18:54:30 -0700 From: Stephen Boyd To: Maxime Ripard Cc: Chen-Yu Tsai , Mike Turquette , Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni Subject: Re: [PATCH v3 01/21] clk: divider: Make divider_round_rate take the parent clock Message-ID: <20170519015430.GF20170@codeaurora.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-ID: On 05/17, Maxime Ripard wrote: > So far, divider_round_rate only considers the parent clock returned by > clk_hw_get_parent. > > This works fine on clocks that have a single parents, this doesn't work on > muxes, since we will only consider the first parent, while other parents > may totally be able to provide a better combination. > > Clocks in that case cannot use divider_round_rate, so would have to come up > with a very similar logic to work around it. Instead of having to do > something like this, and duplicate that logic everywhere, create a > divider_round_rate parent to allow caller to give an additional parameter > for the parent clock to consider. > > Reviewed-by: Chen-Yu Tsai > Signed-off-by: Maxime Ripard > --- Acked-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: sboyd@codeaurora.org (Stephen Boyd) Date: Thu, 18 May 2017 18:54:30 -0700 Subject: [PATCH v3 01/21] clk: divider: Make divider_round_rate take the parent clock In-Reply-To: References: Message-ID: <20170519015430.GF20170@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/17, Maxime Ripard wrote: > So far, divider_round_rate only considers the parent clock returned by > clk_hw_get_parent. > > This works fine on clocks that have a single parents, this doesn't work on > muxes, since we will only consider the first parent, while other parents > may totally be able to provide a better combination. > > Clocks in that case cannot use divider_round_rate, so would have to come up > with a very similar logic to work around it. Instead of having to do > something like this, and duplicate that logic everywhere, create a > divider_round_rate parent to allow caller to give an additional parameter > for the parent clock to consider. > > Reviewed-by: Chen-Yu Tsai > Signed-off-by: Maxime Ripard > --- Acked-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v3 01/21] clk: divider: Make divider_round_rate take the parent clock Date: Thu, 18 May 2017 18:54:30 -0700 Message-ID: <20170519015430.GF20170@codeaurora.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maxime Ripard Cc: Thomas Petazzoni , devicetree@vger.kernel.org, Mike Turquette , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chen-Yu Tsai , Daniel Vetter , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org T24gMDUvMTcsIE1heGltZSBSaXBhcmQgd3JvdGU6Cj4gU28gZmFyLCBkaXZpZGVyX3JvdW5kX3Jh dGUgb25seSBjb25zaWRlcnMgdGhlIHBhcmVudCBjbG9jayByZXR1cm5lZCBieQo+IGNsa19od19n ZXRfcGFyZW50Lgo+IAo+IFRoaXMgd29ya3MgZmluZSBvbiBjbG9ja3MgdGhhdCBoYXZlIGEgc2lu Z2xlIHBhcmVudHMsIHRoaXMgZG9lc24ndCB3b3JrIG9uCj4gbXV4ZXMsIHNpbmNlIHdlIHdpbGwg b25seSBjb25zaWRlciB0aGUgZmlyc3QgcGFyZW50LCB3aGlsZSBvdGhlciBwYXJlbnRzCj4gbWF5 IHRvdGFsbHkgYmUgYWJsZSB0byBwcm92aWRlIGEgYmV0dGVyIGNvbWJpbmF0aW9uLgo+IAo+IENs b2NrcyBpbiB0aGF0IGNhc2UgY2Fubm90IHVzZSBkaXZpZGVyX3JvdW5kX3JhdGUsIHNvIHdvdWxk IGhhdmUgdG8gY29tZSB1cAo+IHdpdGggYSB2ZXJ5IHNpbWlsYXIgbG9naWMgdG8gd29yayBhcm91 bmQgaXQuIEluc3RlYWQgb2YgaGF2aW5nIHRvIGRvCj4gc29tZXRoaW5nIGxpa2UgdGhpcywgYW5k IGR1cGxpY2F0ZSB0aGF0IGxvZ2ljIGV2ZXJ5d2hlcmUsIGNyZWF0ZSBhCj4gZGl2aWRlcl9yb3Vu ZF9yYXRlIHBhcmVudCB0byBhbGxvdyBjYWxsZXIgdG8gZ2l2ZSBhbiBhZGRpdGlvbmFsIHBhcmFt ZXRlcgo+IGZvciB0aGUgcGFyZW50IGNsb2NrIHRvIGNvbnNpZGVyLgo+IAo+IFJldmlld2VkLWJ5 OiBDaGVuLVl1IFRzYWkgPHdlbnNAY3NpZS5vcmc+Cj4gU2lnbmVkLW9mZi1ieTogTWF4aW1lIFJp cGFyZCA8bWF4aW1lLnJpcGFyZEBmcmVlLWVsZWN0cm9ucy5jb20+Cj4gLS0tCgpBY2tlZC1ieTog U3RlcGhlbiBCb3lkIDxzYm95ZEBjb2RlYXVyb3JhLm9yZz4KCi0tIApRdWFsY29tbSBJbm5vdmF0 aW9uIENlbnRlciwgSW5jLiBpcyBhIG1lbWJlciBvZiBDb2RlIEF1cm9yYSBGb3J1bSwKYSBMaW51 eCBGb3VuZGF0aW9uIENvbGxhYm9yYXRpdmUgUHJvamVjdApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK