From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Amitkumar Karwar <amitkarwar@gmail.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Ganapathi Bhat <gbhat@marvell.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Brian Norris <briannorris@chromium.org>
Subject: Re: [v2] mwifiex: pcie: de-duplicate buffer allocation code
Date: Fri, 19 May 2017 06:01:36 +0000 (UTC) [thread overview]
Message-ID: <20170519060136.CA44A60EC7@smtp.codeaurora.org> (raw)
In-Reply-To: <20170518163447.29496-1-briannorris@chromium.org>
Brian Norris <briannorris@chromium.org> wrote:
> This code was duplicated as part of the PCIe FLR code added to this
> driver. Let's de-duplicate it to:
>
> * make things easier to read (mwifiex_pcie_free_buffers() now has a
> corresponding mwifiex_pcie_alloc_buffers())
> * reduce likelihood of bugs
> * make error logging equally verbose
> * save lines of code!
>
> Also drop some of the commentary that isn't really needed.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Patch applied to wireless-drivers-next.git, thanks.
d41bf5c1c0ed mwifiex: pcie: de-duplicate buffer allocation code
--
https://patchwork.kernel.org/patch/9734777/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2017-05-19 6:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 16:34 [PATCH v2] mwifiex: pcie: de-duplicate buffer allocation code Brian Norris
2017-05-19 6:01 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519060136.CA44A60EC7@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=briannorris@chromium.org \
--cc=gbhat@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.