All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: surenderpolsani@gmail.com
Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
	pmeerw@pmeerw.net, gregor.boirie@parrot.com,
	devel@driverdev.osuosl.org, eraretuya@gmail.com,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	maitysanchayan@gmail.com, singhalsimran0@gmail.com
Subject: Re: [PATCH v2] staging: iio: light: Replace symbolic permissions as per coding style
Date: Fri, 19 May 2017 10:20:41 +0200	[thread overview]
Message-ID: <20170519082041.GA18353@kroah.com> (raw)
In-Reply-To: <1495181575-30604-1-git-send-email-surenderpolsani@gmail.com>

On Fri, May 19, 2017 at 01:42:55PM +0530, surenderpolsani@gmail.com wrote:
> -static DEVICE_ATTR(power_state, S_IRUGO | S_IWUSR,
> -		tsl2x7x_power_state_show, tsl2x7x_power_state_store);
> +static DEVICE_ATTR_RW(tsl2x7x_power_state);

You do realize you just renamed the sysfs file, changing the user/kernel
api?  That's generally not a good thing to ever do :(

thanks,

greg k-h

  reply	other threads:[~2017-05-19  8:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18  8:36 [PATCH] staging: iio: light: Replace symbolic permissions as per coding style surenderpolsani
2017-05-18  9:06 ` Greg KH
2017-05-19  7:03   ` [PATCH v2] " surenderpolsani
2017-05-19  7:15     ` Greg KH
2017-05-19  7:36       ` suri
2017-05-19  8:12   ` surenderpolsani
2017-05-19  8:20     ` Greg KH [this message]
2017-05-19  9:37       ` [PATCH v3] " surenderpolsani
2017-05-20 17:55         ` Jonathan Cameron
2017-05-20 18:36           ` Brian Masney
2017-05-21 10:55             ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170519082041.GA18353@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=eraretuya@gmail.com \
    --cc=gregor.boirie@parrot.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maitysanchayan@gmail.com \
    --cc=pmeerw@pmeerw.net \
    --cc=singhalsimran0@gmail.com \
    --cc=surenderpolsani@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.