All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: Eric DeVolder <eric.devolder@oracle.com>
Cc: andrew.cooper3@citrix.com, daniel.kiper@oracle.com,
	horms@verge.net.au, kexec@lists.infradead.org,
	konrad.wilk@oracle.com
Subject: Re: [PATCH] Handle additional e820 memmap type strings
Date: Fri, 19 May 2017 17:15:38 +0800	[thread overview]
Message-ID: <20170519091538.GA24903@x1> (raw)
In-Reply-To: <ff7c75d3-2b12-fe7a-8ede-ec04a6161665@oracle.com>

On 05/17/17 at 07:51am, Eric DeVolder wrote:
> > > diff --git a/kexec/firmware_memmap.c b/kexec/firmware_memmap.c
> > > index 4d84f00..1ee214a 100644
> > > --- a/kexec/firmware_memmap.c
> > > +++ b/kexec/firmware_memmap.c
> > > @@ -164,6 +164,10 @@ static int parse_memmap_entry(const char *entry, struct memory_range *range)
> > >   		range->type = RANGE_RESERVED;
> > >   	else if (strcmp(type, "reserved") == 0)
> > >   		range->type = RANGE_RESERVED;
> > > +	else if (strcmp(type, "Reserved") == 0)
> > > +		range->type = RANGE_RESERVED;
> > > +	else if (strcmp(type, "Unknown E820 type") == 0)
> > > +		range->type = RANGE_RESERVED;
> > 
> > Should we change the "reserved" one to "Reserved" so that we don't need
> > to have "reserved" and "Reserved" at the same time?
> 
> The lower-case "reserved" has been in use by the kernel for quite a long
> while, and upper-case "Reserved" has been recently introduced. I think
> removing lower-case "reserved" would result in problems with existing,
> older, kernels that still would be using "reserved".

Thanks. Then it looks good to me. Ack.

Simon might pick several patches one time every several days. Please
wait.
> 
> > 
> > >   	else if (strcmp(type, "ACPI Non-volatile Storage") == 0)
> > >   		range->type = RANGE_ACPI_NVS;
> > >   	else if (strcmp(type, "Uncached RAM") == 0)
> > > -- 
> > > 2.7.4
> > > 
> > > 
> > > _______________________________________________
> > > kexec mailing list
> > > kexec@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/kexec
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2017-05-19  9:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-10 16:03 [PATCH] Handle additional e820 memmap type strings Eric DeVolder
2017-05-14 23:28 ` Eric DeVolder
2017-05-15 14:07 ` Baoquan He
2017-05-17 12:51   ` Eric DeVolder
2017-05-19  9:15     ` Baoquan He [this message]
2017-05-22 11:43       ` Simon Horman
2017-05-23 14:08         ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170519091538.GA24903@x1 \
    --to=bhe@redhat.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=daniel.kiper@oracle.com \
    --cc=eric.devolder@oracle.com \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=konrad.wilk@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.