From: Miroslav Lichvar <mlichvar@redhat.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Network Development <netdev@vger.kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH v5 net-next 4/7] net: add new control message for incoming HW-timestamped packets
Date: Fri, 19 May 2017 12:04:28 +0200 [thread overview]
Message-ID: <20170519100428.GC21003@localhost> (raw)
In-Reply-To: <CAF=yD-+FCccqtF0oeqeph=dvrUJ8Byd8q_uWqZk+zvxYYtC_Fw@mail.gmail.com>
On Thu, May 18, 2017 at 04:20:53PM -0400, Willem de Bruijn wrote:
> On Thu, May 18, 2017 at 10:07 AM, Miroslav Lichvar <mlichvar@redhat.com> wrote:
> > +SOF_TIMESTAMPING_OPT_PKTINFO:
> > +
> > + Enable the SCM_TIMESTAMPING_PKTINFO control message for incoming
> > + packets with hardware timestamps. The message contains struct
> > + scm_ts_pktinfo, which supplies the index of the real interface which
> > + received the packet and its length at layer 2. A valid (non-zero)
> > + interface index will be returned only if CONFIG_NET_RX_BUSY_POLL is
> > + enabled and the driver is using NAPI.
>
> It is probably good to explicitly call out that the remaining two fields
> are reserved and undefined. To stress that applications cannot be
> overly pedantic and start failing if these become non-zero.
Ok. I'm adding "The struct contains also two other fields, but they
are reserved and undefined".
--
Miroslav Lichvar
next prev parent reply other threads:[~2017-05-19 10:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 14:07 [PATCH v5 net-next 0/7] Extend socket timestamping API Miroslav Lichvar
2017-05-18 14:07 ` [PATCH v5 net-next 1/7] net: define receive timestamp filter for NTP Miroslav Lichvar
2017-05-18 14:07 ` [PATCH v5 net-next 2/7] net: ethernet: update drivers to handle HWTSTAMP_FILTER_NTP_ALL Miroslav Lichvar
2017-05-18 14:07 ` [PATCH v5 net-next 3/7] net: add function to retrieve original skb device using NAPI ID Miroslav Lichvar
2017-05-18 14:07 ` [PATCH v5 net-next 4/7] net: add new control message for incoming HW-timestamped packets Miroslav Lichvar
2017-05-18 20:20 ` Willem de Bruijn
2017-05-19 10:04 ` Miroslav Lichvar [this message]
2017-05-18 14:07 ` [PATCH v5 net-next 5/7] net: fix documentation of struct scm_timestamping Miroslav Lichvar
2017-05-18 19:38 ` Willem de Bruijn
2017-05-19 10:11 ` Miroslav Lichvar
2017-05-19 15:23 ` Willem de Bruijn
2017-05-18 14:07 ` [PATCH v5 net-next 6/7] net: allow simultaneous SW and HW transmit timestamping Miroslav Lichvar
2017-05-18 14:07 ` [PATCH v5 net-next 7/7] net: ethernet: update drivers to make both SW and HW TX timestamps Miroslav Lichvar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519100428.GC21003@localhost \
--to=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.