From: David Sterba <dsterba@suse.cz>
To: Liu Bo <bo.li.liu@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 06/10] btrfs: scrub: use bool for flush_all_writes
Date: Fri, 19 May 2017 15:08:22 +0200 [thread overview]
Message-ID: <20170519130822.GU4065@suse.cz> (raw)
In-Reply-To: <20170519004224.GK23822@lim.localdomain>
On Thu, May 18, 2017 at 05:42:24PM -0700, Liu Bo wrote:
> On Tue, May 16, 2017 at 07:10:38PM +0200, David Sterba wrote:
> > flush_all_writes is an atomic but does not use the semantics at all,
> > it's just on/off indicator, we can use bool.
> >
>
> It might use atomic to avoid reordering, but I'm not sure if
> reordering could really happen here.
Ok, I'll have a look. It does not seem to rely on atomics/ordering though.
next prev parent reply other threads:[~2017-05-19 13:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 17:10 [PATCH 00/10] Btrfs, minor scrub code cleanups David Sterba
2017-05-16 17:10 ` [PATCH 01/10] btrfs: scrub: inline helper scrub_setup_wr_ctx David Sterba
2017-05-16 17:10 ` [PATCH 02/10] btrfs: scrub: inline helper scrub_free_wr_ctx David Sterba
2017-05-16 17:10 ` [PATCH 03/10] btrfs: scrub: simplify cleanup of wr_ctx in scrub_free_ctx David Sterba
2017-05-19 0:25 ` Liu Bo
2017-05-16 17:10 ` [PATCH 04/10] btrfs: scrub: embed scrub_wr_ctx into scrub context David Sterba
2017-05-16 17:10 ` [PATCH 05/10] btrfs: scrub: remove pages_per_wr_bio from " David Sterba
2017-05-16 17:10 ` [PATCH 06/10] btrfs: scrub: use bool for flush_all_writes David Sterba
2017-05-19 0:42 ` Liu Bo
2017-05-19 13:08 ` David Sterba [this message]
2017-05-29 14:59 ` David Sterba
2017-05-16 17:10 ` [PATCH 07/10] btrfs: scrub: use fs_info::sectorsize and drop it from scrub context David Sterba
2017-05-19 0:43 ` Liu Bo
2017-05-16 17:10 ` [PATCH 08/10] btrfs: scrub: clean up division in __scrub_mark_bitmap David Sterba
2017-05-16 17:10 ` [PATCH 09/10] btrfs: scrub: clean up division in scrub_find_csum David Sterba
2017-05-16 17:10 ` [PATCH 10/10] btrfs: scrub: simplify srrub worker initialization David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519130822.GU4065@suse.cz \
--to=dsterba@suse.cz \
--cc=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.