From: David Sterba <dsterba@suse.cz>
To: Sargun Dhillon <sargun@sargun.me>
Cc: BTRFS ML <linux-btrfs@vger.kernel.org>,
Qu Wenruo <quwenruo@cn.fujitsu.com>
Subject: Re: [PATCH v2 0/2] btrfs: allow mechanism to override quota
Date: Fri, 19 May 2017 15:26:08 +0200 [thread overview]
Message-ID: <20170519132608.GV4065@suse.cz> (raw)
In-Reply-To: <CAMp4zn8AZtYs21Cf-6_kfRjGS0khe5ScpEe__H6XC4i-Ci=ZQw@mail.gmail.com>
On Fri, May 19, 2017 at 01:39:49AM -0700, Sargun Dhillon wrote:
> On Fri, May 12, 2017 at 7:48 AM, David Sterba <dsterba@suse.cz> wrote:
> > On Thu, May 11, 2017 at 09:17:01PM +0000, Sargun Dhillon wrote:
> >> This patchset makes it so that on a per-filesystem basis one can disable
> >> quota enforcement for users with cap_sys_resource. This patchset can
> >> likely later be extended to per-qgroup, or a per-volume basis. I'm
> >> thinking of extending the sysfs interface to list the qgroups and
> >> this same interface for the qgroups themselves.
> >>
> >> Changes since v1:
> >> -Rather than a separate member of btrfs_fs_info, use the existing
> >> flags field
> >
> > Looks good to me, thanks.
> I'm curious as to whether this approach is fine to get an Acked-by,
This was meant as an acked-by, the patch is now queued for 4.13, but as
it add some user-visible interface, this may need more time to see if we
haven't missed something.
> or
> if I need to figure out how to make it more leak-tolerant. I don't
> think modifying the overridden extents inflight is a problem. I'm not
> sure of a way a user would be able to create *new* chunks of data.
> Alternatively, I'd be quite happy making this applicable to metadata
> only, for file xattrs, creation, deletion, etc..
>From the interface POV, this can be set as a bitmask. I haven't looked
if we'd be able to propagate all the changes everywhere in the code,
but sounds doable, bug I'm not sure if this level of fine-grained control
is desired.
prev parent reply other threads:[~2017-05-19 13:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 21:17 [PATCH v2 0/2] btrfs: allow mechanism to override quota Sargun Dhillon
2017-05-11 21:17 ` [PATCH v2 1/2] btrfs: add quota override flag to enable quota override for sys_resource Sargun Dhillon
2017-05-11 21:18 ` [PATCH v2 2/2] btrfs: Add quota_override knob into sysfs Sargun Dhillon
2017-05-12 14:48 ` [PATCH v2 0/2] btrfs: allow mechanism to override quota David Sterba
2017-05-19 8:39 ` Sargun Dhillon
2017-05-19 13:26 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519132608.GV4065@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
--cc=sargun@sargun.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.