All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next V5 0/9] vhost_net rx batch dequeuing
Date: Fri, 19 May 2017 19:36:49 +0300	[thread overview]
Message-ID: <20170519193636-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <0d1dbf31-32c8-34b4-d8e8-48d04f2fc205@redhat.com>

On Fri, May 19, 2017 at 02:27:16PM +0800, Jason Wang wrote:
> 
> 
> On 2017年05月18日 04:59, Michael S. Tsirkin wrote:
> > On Wed, May 17, 2017 at 12:14:36PM +0800, Jason Wang wrote:
> > > This series tries to implement rx batching for vhost-net. This is done
> > > by batching the dequeuing from skb_array which was exported by
> > > underlayer socket and pass the sbk back through msg_control to finish
> > > userspace copying. This is also the requirement for more batching
> > > implemention on rx path.
> > > 
> > > Tests shows at most 7.56% improvment bon rx pps on top of batch
> > > zeroing and no obvious changes for TCP_STREAM/TCP_RR result.
> > > 
> > > Please review.
> > > 
> > > Thanks
> > A surprisingly large gain for such as simple change.  It would be nice
> > to understand better why this helps - in particular, does the optimal
> > batch size change if ring is bigger or smaller?
> 
> Will test, just want to confirm. You mean virtio ring not tx_queue_len here?
> 
> Thanks

Exactly.
Thanks,
MST

  reply	other threads:[~2017-05-19 16:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-17  4:14 [PATCH net-next V5 0/9] vhost_net rx batch dequeuing Jason Wang
2017-05-17  4:14 ` [PATCH net-next V5 1/9] ptr_ring: add ptr_ring_unconsume Jason Wang
2017-05-17  4:14 ` [PATCH net-next V5 2/9] skb_array: introduce skb_array_unconsume Jason Wang
2017-05-17  4:14 ` [PATCH net-next V5 3/9] ptr_ring: introduce batch dequeuing Jason Wang
2017-05-17  4:14 ` [PATCH net-next V5 4/9] skb_array: " Jason Wang
2017-05-17  4:14 ` [PATCH net-next V5 5/9] tun: export skb_array Jason Wang
2017-05-17  4:14 ` [PATCH net-next V5 6/9] tap: " Jason Wang
2017-05-17  4:14 ` [PATCH net-next V5 7/9] tun: support receiving skb through msg_control Jason Wang
2017-05-17  4:14 ` [PATCH net-next V5 8/9] tap: support receiving skb from msg_control Jason Wang
2017-05-17  4:14 ` [PATCH net-next V5 9/9] vhost_net: try batch dequing from skb array Jason Wang
2017-05-17 20:59 ` [PATCH net-next V5 0/9] vhost_net rx batch dequeuing Michael S. Tsirkin
2017-05-19  6:27   ` Jason Wang
2017-05-19 16:36     ` Michael S. Tsirkin [this message]
2017-05-18 14:08 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170519193636-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.