meta-python: outrageously long cython shebang with pyro

meta-python: outrageously long cython shebang with pyro

[S. Lockwood-Childs]

The recipe-specific sysroots in pyro are a wonderful thing for uncovering 
missing dependencies, but they also make it easier than ever to break
the cython scripts by exceeding the measly 128-byte limit on shebang lines. 

The cython recipe builds fine -- this is runtime breakage from recipes that
depend on cython. This was always a danger when using lengthy toplevel
directory names (e.g. as tends to happen in jenkins auto-builds), but
now I managed to get the dreaded "bad interpreter: No such file or directory"
failure from cython despite a not-ridiculously-long toplevel path:

#!/var/data/sjl/poky/build/tmp/work/armv7a-neon-oe-linux-gnueabi/libplist/git-r0/recipe-sysroot-native/usr/bin/python-native/python

Does anybody know of a recommended strategy for solving the shebang problem,
now that it has been exacerbated by the sysroot move? I'll be happy to submit a
corresponding cython patch if so. 

Re: meta-python: outrageously long cython shebang with pyro

[Alexander Kanavin]

On 05/13/2017 09:34 AM, S. Lockwood-Childs wrote:
> The cython recipe builds fine -- this is runtime breakage from recipes that
> depend on cython. This was always a danger when using lengthy toplevel
> directory names (e.g. as tends to happen in jenkins auto-builds), but
> now I managed to get the dreaded "bad interpreter: No such file or directory"
> failure from cython despite a not-ridiculously-long toplevel path:
>
> #!/var/data/sjl/poky/build/tmp/work/armv7a-neon-oe-linux-gnueabi/libplist/git-r0/recipe-sysroot-native/usr/bin/python-native/python

We typically patch the upstream code to use

#!/usr/bin/env python

There is some PATH environment variable magic that will ensure that the 
correct version of python will come first in the PATH, so it should be 
safe to do. There's a ton of examples in oe-core.


Alex

[meta-python][master][pyro][PATCH] python-cython: mangle scripts to use /usr/bin/env python

[S. Lockwood-Childs]

This prevents runtime failure "bad interpreter: No such file or directory"
from running native cython when the native python is installed
at a long path, exceeding the 128-character limit for shebang lines
on linux. Exceeding the limit was already possible when using a long
path for topdir, but it got easier to exceed after the switch to per-recipe
sysroots.

Signed-off-by: S. Lockwood-Childs <sjl@vctlabs.com>
---
 meta-python/recipes-devtools/python/python-cython.inc | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/meta-python/recipes-devtools/python/python-cython.inc b/meta-python/recipes-devtools/python/python-cython.inc
index 1ecdcc9..66383bf 100644
--- a/meta-python/recipes-devtools/python/python-cython.inc
+++ b/meta-python/recipes-devtools/python/python-cython.inc
@@ -17,3 +17,10 @@ RDEPENDS_${PN}_class-target += "\
     ${PYTHON_PN}-subprocess \
     ${PYTHON_PN}-shell \
 "
+
+do_install_append() {
+	# Make sure we use /usr/bin/env python
+	for PYTHSCRIPT in `grep -rIl '^!#.*python' ${D}${bindir}`; do
+		sed -i -e '1s|^#!.*|#!/usr/bin/env ${PYTHON_PN}|' $PYTHSCRIPT
+	done
+}
-- 
1.9.4

[meta-python][master][pyro][PATCH, v2] python-cython: mangle scripts to use /usr/bin/env python

[S. Lockwood-Childs]

This prevents runtime failure "bad interpreter: No such file or directory"                                              
from running native cython when the native python is installed                                                          
at a long path, exceeding the 128-character limit for shebang lines                                                     
on linux. Exceeding the limit was already possible when using a long                                                    
path for topdir, but it got easier to exceed after the switch to per-recipe                                             
sysroots.                                                                                                               
---
 meta-python/recipes-devtools/python/python-cython.inc | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/meta-python/recipes-devtools/python/python-cython.inc b/meta-python/recipes-devtools/python/python-cython.inc
index 1ecdcc9..22b49f3 100644
--- a/meta-python/recipes-devtools/python/python-cython.inc
+++ b/meta-python/recipes-devtools/python/python-cython.inc
@@ -17,3 +17,10 @@ RDEPENDS_${PN}_class-target += "\
     ${PYTHON_PN}-subprocess \
     ${PYTHON_PN}-shell \
 "
+
+do_install_append() {
+	# Make sure we use /usr/bin/env python
+	for PYTHSCRIPT in `grep -rIl '^!#.*python' ${D}`; do
+		sed -i -e '1s|^#!.*|#!/usr/bin/env ${PYTHON_PN}|' $PYTHSCRIPT
+	done
+}
-- 
1.9.4

[meta-python][master][pyro][PATCH, v3] python-cython: mangle scripts to use /usr/bin/env python

[S. Lockwood-Childs]

This prevents runtime failure "bad interpreter: No such file or directory"
from running native cython when the native python is installed
at a long path, exceeding the 128-character limit for shebang lines
on linux. Exceeding the limit was already possible when using a long
path for topdir, but it got easier to exceed after the switch to per-recipe
sysroots.
---
 meta-python/recipes-devtools/python/python-cython.inc | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/meta-python/recipes-devtools/python/python-cython.inc b/meta-python/recipes-devtools/python/python-cython.inc
index 1ecdcc9..da39d14 100644
--- a/meta-python/recipes-devtools/python/python-cython.inc
+++ b/meta-python/recipes-devtools/python/python-cython.inc
@@ -17,3 +17,10 @@ RDEPENDS_${PN}_class-target += "\
     ${PYTHON_PN}-subprocess \
     ${PYTHON_PN}-shell \
 "
+
+do_install_append() {
+	# Make sure we use /usr/bin/env python
+	for PYTHSCRIPT in `grep -rIl '^#!.*python' ${D}`; do
+		sed -i -e '1s|^#!.*|#!/usr/bin/env ${PYTHON_PN}|' $PYTHSCRIPT
+	done
+}
-- 
1.9.4