From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH 2/2 v2] input: keyboard: Add D-Link DIR-685 touchkeys driver
Date: Sat, 20 May 2017 10:26:48 -0700 [thread overview]
Message-ID: <20170520172648.GA38800@dtor-ws> (raw)
In-Reply-To: <20170520165746.13356-2-linus.walleij@linaro.org>
Hi Linus,
On Sat, May 20, 2017 at 06:57:46PM +0200, Linus Walleij wrote:
> + tk->codes[0] = KEY_UP;
> + tk->codes[1] = KEY_DOWN;
> + tk->codes[2] = KEY_LEFT;
> + tk->codes[3] = KEY_RIGHT;
> + tk->codes[4] = KEY_ENTER;
> + tk->codes[5] = KEY_W;
> + tk->codes[6] = KEY_O;
Why 'W' and 'O'? I do not think the router software expects users to
"type" these letters? Could it have something to do with WPS and maybe
something else?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2017-05-20 17:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-20 16:57 [PATCH 1/2 v2] input: keyboard: DT bindings for the D-Link DIR-685 touchkeys Linus Walleij
2017-05-20 16:57 ` [PATCH 2/2 v2] input: keyboard: Add D-Link DIR-685 touchkeys driver Linus Walleij
2017-05-20 17:26 ` Dmitry Torokhov [this message]
2017-05-30 12:03 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170520172648.GA38800@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.