From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751315AbdEUHks (ORCPT <rfc822;w@1wt.eu>);
        Sun, 21 May 2017 03:40:48 -0400
Received: from mga02.intel.com ([134.134.136.20]:17300 "EHLO mga02.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750786AbdEUHkr (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 21 May 2017 03:40:47 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,373,1491289200"; 
   d="scan'208";a="264533875"
Date: Sun, 21 May 2017 10:40:41 +0300
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: "Levy, Amir (Jer)" <amir.jer.levy@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andreas Noever <andreas.noever@gmail.com>,
        "Jamet, Michael" <michael.jamet@intel.com>,
        "Bernat, Yehezkel" <yehezkel.bernat@intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        "Mario.Limonciello@dell.com" <Mario.Limonciello@dell.com>,
        "Jared.Dominguez@dell.com" <Jared.Dominguez@dell.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the
 switch structure
Message-ID: <20170521074041.GK8541@lahna.fi.intel.com>
References: <20170518143914.60902-1-mika.westerberg@linux.intel.com>
 <20170518143914.60902-19-mika.westerberg@linux.intel.com>
 <20170521044735.GA2948@wunner.de>
 <E607265CB020454880711A6F96C05A030106862644@hasmsx107.ger.corp.intel.com>
 <20170521053521.GB3003@wunner.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170521053521.GB3003@wunner.de>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, May 21, 2017 at 07:35:21AM +0200, Lukas Wunner wrote:
> On Sun, May 21, 2017 at 05:29:47AM +0000, Levy, Amir (Jer) wrote:
> > On Sun, May 21 2017, 07:47 AM, Lukas Wunner wrote:
> > > On Thu, May 18, 2017 at 05:39:08PM +0300, Mika Westerberg wrote:
> > > > +
> > > > +	default:
> > > > +		sw->generation = 1;
> > > > +		break;
> > > 
> > > If someone adds an entry for, say, a new TB3 controller to nhi_ids[] but
> > > forgets to update this function, the controller is assigned the wrong
> > > generation number.  It might be better to make TB3 the default and list
> > > each TB1 controller instead since it's less likely for Intel to introduce
> > > an older gen chip.
> > > 
> > > Generally I think it's problematic to require that multiple files are
> > > touched whenever a new controller is added.  Isn't the generation number
> > > or link speed (10/20/40) stored in some register in PCI config space
> > > (VSEC 0x1234) or TB config space?
> > 
> > How about setting information, that isn't available from PCI, in
> > pci_device_id.driver_data when initializing nhi_ids[]?
> 
> Right, that would also be possible, though reading the generation number
> from a register would be more elegant, if such a register exists.

I don't think there is such register but I can put this information to
the driver_data instead.