From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751889AbdEUIJD (ORCPT <rfc822;w@1wt.eu>);
        Sun, 21 May 2017 04:09:03 -0400
Received: from mga09.intel.com ([134.134.136.24]:36613 "EHLO mga09.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750786AbdEUIJC (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 21 May 2017 04:09:02 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,373,1491289200"; 
   d="scan'208";a="1172283753"
Date: Sun, 21 May 2017 11:08:55 +0300
From: "mika.westerberg@linux.intel.com" <mika.westerberg@linux.intel.com>
To: "Levy, Amir (Jer)" <amir.jer.levy@intel.com>
Cc: "Mario.Limonciello@dell.com" <Mario.Limonciello@dell.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "andreas.noever@gmail.com" <andreas.noever@gmail.com>,
        "Jamet, Michael" <michael.jamet@intel.com>,
        "Bernat, Yehezkel" <yehezkel.bernat@intel.com>,
        "lukas@wunner.de" <lukas@wunner.de>,
        "luto@kernel.org" <luto@kernel.org>,
        "Jared.Dominguez@dell.com" <Jared.Dominguez@dell.com>,
        "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/24] Thunderbolt security levels and NVM firmware
 upgrade
Message-ID: <20170521080855.GO8541@lahna.fi.intel.com>
References: <20170518143914.60902-1-mika.westerberg@linux.intel.com>
 <799e3a9d4d394d1eb9b9e742d81bd044@ausx13mpc120.AMER.DELL.COM>
 <E607265CB020454880711A6F96C05A03010686211A@hasmsx107.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E607265CB020454880711A6F96C05A03010686211A@hasmsx107.ger.corp.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, May 20, 2017 at 09:15:17AM +0000, Levy, Amir (Jer) wrote:
> > I created a udev rule that will automatically authorize the dock and cable.
> > #dell cable
> > ACTION=="add", SUBSYSTEM=="thunderbolt", ATTR{authorized}=="0",
> > ATTR{vendor}=="0xd4", ATTR{device}=="0xb051", ATTR{authorized}="1"
> > #dell dock
> > ACTION=="add", SUBSYSTEM=="thunderbolt", ATTR{authorized}=="0",
> > ATTR{vendor}=="0xd4", ATTR{device}=="0xb054", ATTR{authorized}="1"
> > 
> 
> Note that the udev rule should authorize the cable first and then the dock.

That should be fine, the devices appear in order closest to the host and
get added to the system in that order so udev should see them in that
order as well. Also the cable device will be parent to the dock.