All of lore.kernel.org
 help / color / mirror / Atom feed
From: Flora Cui <flora.cui-5C7GfCeVMHo@public.gmane.org>
To: zhoucm1 <david1.zhou-5C7GfCeVMHo@public.gmane.org>
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amdgpu: fix ocl test performance drop
Date: Mon, 22 May 2017 18:10:53 +0800	[thread overview]
Message-ID: <20170522101052.GC19238@flora> (raw)
In-Reply-To: <5922A818.9010301-5C7GfCeVMHo@public.gmane.org>

partial revert commit <6971d3d> - drm/amdgpu: cleanup logic in
amdgpu_vm_flush

Change-Id: Iadce9d613dfe9a739643a74050cea55854832adb
Signed-off-by: Flora Cui <Flora.Cui@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 4573d8c..5b9a73d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -743,8 +743,7 @@ int amdgpu_vm_flush(struct amdgpu_ring *ring, struct amdgpu_job *job)
 		id->gws_size != job->gws_size ||
 		id->oa_base != job->oa_base ||
 		id->oa_size != job->oa_size);
-	bool vm_flush_needed = job->vm_needs_flush ||
-		amdgpu_vm_ring_has_compute_vm_bug(ring);
+	bool vm_flush_needed = job->vm_needs_flush;
 	unsigned patch_offset = 0;
 	int r;
 
-- 
2.7.4

On Mon, May 22, 2017 at 04:58:00PM +0800, zhoucm1 wrote:
> 
> 
> On 2017年05月22日 16:34, Flora Cui wrote:
> >partial revert commit <6971d3d> - drm/amdgpu: cleanup logic in
> >amdgpu_vm_flush
> >
> >Change-Id: Iadce9d613dfe9a739643a74050cea55854832adb
> >Signed-off-by: Flora Cui <Flora.Cui@amd.com>
> >---
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> >diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> >index 4573d8c..11d58f7 100644
> >--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> >+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> >@@ -743,8 +743,7 @@ int amdgpu_vm_flush(struct amdgpu_ring *ring, struct amdgpu_job *job)
> >  		id->gws_size != job->gws_size ||
> >  		id->oa_base != job->oa_base ||
> >  		id->oa_size != job->oa_size);
> >-	bool vm_flush_needed = job->vm_needs_flush ||
> >-		amdgpu_vm_ring_has_compute_vm_bug(ring);
> >+	bool vm_flush_needed = job->vm_needs_flush;
> >  	unsigned patch_offset = 0;
> >  	int r;
> >@@ -753,7 +752,8 @@ int amdgpu_vm_flush(struct amdgpu_ring *ring, struct amdgpu_job *job)
> >  		vm_flush_needed = true;
> >  	}
> >-	if (!vm_flush_needed && !gds_switch_needed)
> >+	if (!vm_flush_needed && !gds_switch_needed &&
> >+	    !amdgpu_vm_ring_has_compute_vm_bug(ring))
> >  		return 0;
> here change isn't needed.
> 
> Regards,
> David Zhou
> >  	if (ring->funcs->init_cond_exec)
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2017-05-22 10:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-22  8:34 [PATCH] drm/amdgpu: fix ocl test performance drop Flora Cui
     [not found] ` <1495442049-7481-1-git-send-email-Flora.Cui-5C7GfCeVMHo@public.gmane.org>
2017-05-22  8:58   ` zhoucm1
     [not found]     ` <5922A818.9010301-5C7GfCeVMHo@public.gmane.org>
2017-05-22 10:10       ` Flora Cui [this message]
2017-05-22 11:16         ` Christian König
2017-05-22 11:19         ` 回复: " Zhou, David(ChunMing)
  -- strict thread matches above, loose matches on Subject: below --
2017-05-18  7:45 Flora Cui
     [not found] ` <1495093501-13313-1-git-send-email-Flora.Cui-5C7GfCeVMHo@public.gmane.org>
2017-05-18 11:38   ` Christian König
     [not found]     ` <4b2d410d-544f-4e72-11ae-8db4a1d797d3-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-05-19  2:25       ` Flora Cui
2017-05-19  3:36         ` Flora Cui
2017-05-19  5:16           ` zhoucm1
     [not found]             ` <591E7FA9.4070201-5C7GfCeVMHo@public.gmane.org>
2017-05-19 11:59               ` Christian König
     [not found]                 ` <0246394a-ddbb-6478-b36f-8fb7e9213acb-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-05-22  3:42                   ` Flora Cui
2017-05-22  6:47                     ` Christian König
2017-05-23 17:51           ` Deucher, Alexander
2017-05-19 11:57         ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170522101052.GC19238@flora \
    --to=flora.cui-5c7gfcevmho@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=david1.zhou-5C7GfCeVMHo@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.