From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sowmini Varadhan Date: Mon, 22 May 2017 14:26:51 +0000 Subject: Re: [PATCH 3/3] RDS: TCP: Delete an error message for a failed memory allocation in rds_tcp_init_net Message-Id: <20170522142651.GA29434@oracle.com> List-Id: References: <44b46c51-3665-5f14-dd3b-6e6f230258a7@users.sourceforge.net> <5d523cf8-1540-e704-2301-a5e0205cb536@users.sourceforge.net> In-Reply-To: <5d523cf8-1540-e704-2301-a5e0205cb536-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rds-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org, "David S. Miller" , Santosh Shilimkar , LKML , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On (05/22/17 16:13), SF Markus Elfring wrote: > > Omit an extra message for a memory allocation failure in this function. The change itself is harmless, but I'm curious about the "extra" part: "extra" from what? If this happens, hopefully this will be logged somewhere? Note that this type of (infrequent) logging noise is useful in some cases, e.g., with 8ce675ff, when one is trying to do the post-mortem of where things first went wrong. --Sowmini From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sowmini Varadhan Subject: Re: [PATCH 3/3] RDS: TCP: Delete an error message for a failed memory allocation in rds_tcp_init_net() Date: Mon, 22 May 2017 10:26:51 -0400 Message-ID: <20170522142651.GA29434@oracle.com> References: <44b46c51-3665-5f14-dd3b-6e6f230258a7@users.sourceforge.net> <5d523cf8-1540-e704-2301-a5e0205cb536@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5d523cf8-1540-e704-2301-a5e0205cb536-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: SF Markus Elfring Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rds-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org, "David S. Miller" , Santosh Shilimkar , LKML , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On (05/22/17 16:13), SF Markus Elfring wrote: > > Omit an extra message for a memory allocation failure in this function. The change itself is harmless, but I'm curious about the "extra" part: "extra" from what? If this happens, hopefully this will be logged somewhere? Note that this type of (infrequent) logging noise is useful in some cases, e.g., with 8ce675ff, when one is trying to do the post-mortem of where things first went wrong. --Sowmini -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934647AbdEVO1N (ORCPT ); Mon, 22 May 2017 10:27:13 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:32551 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933917AbdEVO1L (ORCPT ); Mon, 22 May 2017 10:27:11 -0400 Date: Mon, 22 May 2017 10:26:51 -0400 From: Sowmini Varadhan To: SF Markus Elfring Cc: linux-rdma@vger.kernel.org, netdev@vger.kernel.org, rds-devel@oss.oracle.com, "David S. Miller" , Santosh Shilimkar , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/3] RDS: TCP: Delete an error message for a failed memory allocation in rds_tcp_init_net() Message-ID: <20170522142651.GA29434@oracle.com> References: <44b46c51-3665-5f14-dd3b-6e6f230258a7@users.sourceforge.net> <5d523cf8-1540-e704-2301-a5e0205cb536@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5d523cf8-1540-e704-2301-a5e0205cb536@users.sourceforge.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (05/22/17 16:13), SF Markus Elfring wrote: > > Omit an extra message for a memory allocation failure in this function. The change itself is harmless, but I'm curious about the "extra" part: "extra" from what? If this happens, hopefully this will be logged somewhere? Note that this type of (infrequent) logging noise is useful in some cases, e.g., with 8ce675ff, when one is trying to do the post-mortem of where things first went wrong. --Sowmini