From: Christoph Hellwig <hch@infradead.org>
To: Carlos Maiolino <cmaiolino@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3 V2] xfs: Add infrastructure needed for error propagation during buffer IO failure
Date: Mon, 22 May 2017 12:13:22 -0700 [thread overview]
Message-ID: <20170522191322.GD17100@infradead.org> (raw)
In-Reply-To: <20170522153220.25072-3-cmaiolino@redhat.com>
Need to read up on the history and background a bit more, but some
cosmetic comments below:
> + lip = bp->b_fspriv;
> + while (lip != NULL) {
> + next = lip->li_bio_list;
> +
> + if (lip->li_ops->iop_error)
> + lip->li_ops->iop_error(lip, bflags);
> +
> + lip = next;
> + }
for (lip = bp->b_fspriv; lip; lip = next) {
next = lip->li_bio_list;
if (lip->li_ops->iop_error)
lip->li_ops->iop_error(lip, bflags);
}
?
> @@ -1101,6 +1119,7 @@ xfs_buf_iodone_callback_error(
>
> xfs_buf_ioerror(bp, 0);
> xfs_buf_submit(bp);
> +
> return true;
> }
whitespace noise.
next prev parent reply other threads:[~2017-05-22 19:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 15:32 [PATCH 0/3 V2] Resubmit items failed during writeback Carlos Maiolino
2017-05-22 15:32 ` [PATCH 1/3] xfs: use atomic operations to handle xfs_log_item flags Carlos Maiolino
2017-05-22 19:11 ` Christoph Hellwig
2017-05-23 10:35 ` Carlos Maiolino
2017-05-23 10:42 ` Carlos Maiolino
2017-05-24 17:06 ` Brian Foster
2017-06-05 12:54 ` Carlos Maiolino
2017-06-05 13:13 ` Carlos Maiolino
2017-05-22 15:32 ` [PATCH 2/3 V2] xfs: Add infrastructure needed for error propagation during buffer IO failure Carlos Maiolino
2017-05-22 19:13 ` Christoph Hellwig [this message]
2017-05-23 11:21 ` Carlos Maiolino
2017-05-24 17:07 ` Brian Foster
2017-05-26 11:51 ` Brian Foster
2017-05-22 15:32 ` [PATCH 3/3 V2] xfs: Properly retry failed inode items in case of error during buffer writeback Carlos Maiolino
2017-05-24 17:08 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170522191322.GD17100@infradead.org \
--to=hch@infradead.org \
--cc=cmaiolino@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.