All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: aconole@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vhost_net: do not expose MTU feature bit to kernel backend
Date: Mon, 22 May 2017 20:24:23 +0300	[thread overview]
Message-ID: <20170522202344-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20170520080658.337-1-maxime.coquelin@redhat.com>

On Sat, May 20, 2017 at 10:06:58AM +0200, Maxime Coquelin wrote:
> This patch removes MTU from the list of features supported by
> the kernel backend, so that vhost kernel backend does not have
> to advertise it to be negotiated.
> 
> Cc: Aaron Conole <aconole@redhat.com>
> Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>

This will break cross-version migration when the kernel
does not advertise it though. I'm afraid we'll need
a compat flag.

> ---
>  hw/net/vhost_net.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> index 22874a9..bdd8633 100644
> --- a/hw/net/vhost_net.c
> +++ b/hw/net/vhost_net.c
> @@ -51,7 +51,6 @@ static const int kernel_feature_bits[] = {
>      VIRTIO_RING_F_EVENT_IDX,
>      VIRTIO_NET_F_MRG_RXBUF,
>      VIRTIO_F_VERSION_1,
> -    VIRTIO_NET_F_MTU,
>      VIRTIO_F_IOMMU_PLATFORM,
>      VHOST_INVALID_FEATURE_BIT
>  };
> -- 
> 2.9.3

  parent reply	other threads:[~2017-05-22 17:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-20  8:06 [Qemu-devel] [PATCH] vhost_net: do not expose MTU feature bit to kernel backend Maxime Coquelin
2017-05-20 11:43 ` Aaron Conole
2017-05-22 17:24 ` Michael S. Tsirkin [this message]
2017-05-23  9:39   ` Maxime Coquelin
2017-05-23 12:31 ` [Qemu-devel] [PATCH v2] virtio_net: Bypass backends for MTU feature negotiation Maxime Coquelin
2017-05-23 13:11   ` Vlad Yasevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170522202344-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=aconole@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.