From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Marcel Partap <mpartap-hi6Y0CQ0nG0@public.gmane.org>,
Michael Scott
<michael.scott-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH] power: supply: cpcap-battery: Add a battery driver
Date: Mon, 22 May 2017 17:38:32 -0700 [thread overview]
Message-ID: <20170523003831.GU10472@atomide.com> (raw)
In-Reply-To: <20170520170533.GN10472-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
* Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> [170520 10:09]:
> * Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> [170518 22:55]:
> > Note that I left out the battery interrupt handling for now as I need
> > to spend more time on it for the battery empty interrupts. The driver
> > works just fine without the interrupts too.
> ...
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
> > @@ -0,0 +1,27 @@
> > +Motorola CPCAP PMIC battery driver binding
> > +
> > +Required properties:
> > +- compatible: Shall be "motorola,cpcap-battery"
> > +- interrupts: Interrupt specifier for each name in interrupt-names
> > +- interrupt-names: Should contain the following entries:
> > + "lowbph", "lowbpl", "chrgcurr1", "battdetb"
> > +- io-channels: IIO ADC channel specifier for each name in io-channel-names
> > +- io-channel-names: Should contain the following entries:
> > + "battdetb", "battp"
> > +
> > +Example:
> > +
> > +cpcap_battery: battery {
> > + compatible = "motorola,cpcap-battery";
> > + interrupts-extended = <
> > + &cpcap 5 0 &cpcap 3 0
> > + &cpcap 20 0 &cpcap 54 0
> > + >;
> > + interrupt-names =
> > + "lowbph", "lowbpl",
> > + "chrgcurr1", "battdetb";
> > + io-channels = <&cpcap_adc 0 &cpcap_adc 1
> > + &cpcap_adc 5 &cpcap_adc 6>;
> > + io-channel-names = "battdetb", "battp",
> > + "chg_isense", "batti";
> > +};
>
> I guess we should leave out the interrupts in the binding for now
> too. Or at least move them to optional properties.
Never mind, I got the battery low interrupts finally working. Will
post v2 with interrupts shortly.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-05-23 0:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 5:51 [PATCH] power: supply: cpcap-battery: Add a battery driver Tony Lindgren
2017-05-20 17:05 ` Tony Lindgren
[not found] ` <20170520170533.GN10472-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-05-23 0:38 ` Tony Lindgren [this message]
2017-06-08 21:26 ` Sebastian Reichel
2017-06-12 7:10 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523003831.GU10472@atomide.com \
--to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=michael.scott-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=mpartap-hi6Y0CQ0nG0@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.