Re: [PATCH V4 for-next 02/14] RDMA/bnxt_re: HW workarounds for handling specific conditions

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1661 bytes --]

On Mon, May 22, 2017 at 03:15:32AM -0700, Selvin Xavier wrote:
> From: Eddie Wai <eddie.wai-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
>
> This patch implements the following HW workarounds
>
> 1. The SQ depth needs to be augmented  by 128 + 1 to avoid running
>    into an Out of order CQE issue
> 2. Workaround to handle the problem where the HW fast path engine continues
>    to access DMA memory in retranmission mode even after the WQE has
>    already been completed. If the HW reports this condition, driver detects
>    it and posts a Fence WQE. The driver stops reporting the completions
>    to stack until it receives completion  for Fence WQE.
>
> Signed-off-by: Eddie Wai <eddie.wai-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Selvin Xavier <selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> ---
> v2 -> v3 :
> 	- Fixes the memory leak pointed out by Leon
> v1 -> v2 :
> 	- Small Correction in the commit message
> 	- Fixes q_full_delta for SQ by setting it to 128
>
>  drivers/infiniband/hw/bnxt_re/ib_verbs.c  | 373 ++++++++++++++++++++++++++----
>  drivers/infiniband/hw/bnxt_re/ib_verbs.h  |  15 ++
>  drivers/infiniband/hw/bnxt_re/qplib_fp.c  | 165 +++++++++++--
>  drivers/infiniband/hw/bnxt_re/qplib_fp.h  |  17 +-
>  drivers/infiniband/hw/bnxt_re/qplib_res.h |   1 -
>  drivers/infiniband/hw/bnxt_re/qplib_sp.c  |   5 +
>  drivers/infiniband/hw/bnxt_re/qplib_sp.h  |   2 +
>  7 files changed, 508 insertions(+), 70 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]