From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A50B421A16EF9 for ; Tue, 23 May 2017 01:41:20 -0700 (PDT) Date: Tue, 23 May 2017 10:41:18 +0200 From: Christoph Hellwig Subject: Re: [PATCH 13/23] md: namespace private helper names Message-ID: <20170523084118.GA20121@lst.de> References: <20170518062705.25902-1-hch@lst.de> <20170518062705.25902-14-hch@lst.de> <1495479147.6967.70.camel@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1495479147.6967.70.camel@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Andy Shevchenko Cc: linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, Mimi Zohar , Amir Goldstein , linux-kernel@vger.kernel.org, Steven Whitehouse , David Howells , linux-fsdevel@vger.kernel.org, Shaohua Li , Christoph Hellwig List-ID: On Mon, May 22, 2017 at 09:52:27PM +0300, Andy Shevchenko wrote: > On Thu, 2017-05-18 at 08:26 +0200, Christoph Hellwig wrote: > > From: Amir Goldstein > > > > The md private helper uuid_equal() collides with a generic helper > > of the same name. > > > > Rename the md private helper to md_uuid_equal() and do the same for > > md_sb_equal(). > > > > While patch is good, shouldn't it go before we introduce those helpers? Yes, I'll move it to the beginning of the series. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 13/23] md: namespace private helper names Date: Tue, 23 May 2017 10:41:18 +0200 Message-ID: <20170523084118.GA20121@lst.de> References: <20170518062705.25902-1-hch@lst.de> <20170518062705.25902-14-hch@lst.de> <1495479147.6967.70.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1495479147.6967.70.camel@linux.intel.com> Sender: linux-fsdevel-owner@vger.kernel.org To: Andy Shevchenko Cc: Christoph Hellwig , Amir Goldstein , linux-fsdevel@vger.kernel.org, Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org List-Id: linux-raid.ids On Mon, May 22, 2017 at 09:52:27PM +0300, Andy Shevchenko wrote: > On Thu, 2017-05-18 at 08:26 +0200, Christoph Hellwig wrote: > > From: Amir Goldstein > > > > The md private helper uuid_equal() collides with a generic helper > > of the same name. > > > > Rename the md private helper to md_uuid_equal() and do the same for > > md_sb_equal(). > > > > While patch is good, shouldn't it go before we introduce those helpers? Yes, I'll move it to the beginning of the series. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935932AbdEWIlX (ORCPT ); Tue, 23 May 2017 04:41:23 -0400 Received: from verein.lst.de ([213.95.11.211]:52693 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932549AbdEWIlU (ORCPT ); Tue, 23 May 2017 04:41:20 -0400 Date: Tue, 23 May 2017 10:41:18 +0200 From: Christoph Hellwig To: Andy Shevchenko Cc: Christoph Hellwig , Amir Goldstein , linux-fsdevel@vger.kernel.org, Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 13/23] md: namespace private helper names Message-ID: <20170523084118.GA20121@lst.de> References: <20170518062705.25902-1-hch@lst.de> <20170518062705.25902-14-hch@lst.de> <1495479147.6967.70.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1495479147.6967.70.camel@linux.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 22, 2017 at 09:52:27PM +0300, Andy Shevchenko wrote: > On Thu, 2017-05-18 at 08:26 +0200, Christoph Hellwig wrote: > > From: Amir Goldstein > > > > The md private helper uuid_equal() collides with a generic helper > > of the same name. > > > > Rename the md private helper to md_uuid_equal() and do the same for > > md_sb_equal(). > > > > While patch is good, shouldn't it go before we introduce those helpers? Yes, I'll move it to the beginning of the series.