From: Christoph Hellwig <hch@lst.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Arnd Bergmann <arnd@arndb.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Paolo Valente <paolo.valente@linaro.org>,
Avri Altman <Avri.Altman@sandisk.com>
Subject: Re: [PATCH 5/6] mmc: debugfs: Move card status retrieveal into the block layer
Date: Tue, 23 May 2017 11:52:22 +0200 [thread overview]
Message-ID: <20170523095222.GA25307@lst.de> (raw)
In-Reply-To: <CACRpkdb9yRHiaK7qWarPFdLe3ODeQG9Hh8hG7uB6cb=9svkcWg@mail.gmail.com>
On Tue, May 23, 2017 at 11:49:48AM +0200, Linus Walleij wrote:
> In that case CONFIG_MMC_BLOCK contains 'm' instead of 'y'
> which confusingly does not evaluate to true in the preprocessor
> (it assumes it is a misspelled 'n' I guess).
>
> And then the autobuilders wreak havoc.
>
> And that is why the IS_ENABLED() defines exist in the first
> place IIUC.
>
> I'm all for making CONFIG_MMC_BLOCK into a bool... but
> don't know how people (Intel laptops) feel about that extra
> code in their kernel at all times.
All the time? At least only if any mmc/sd host driver is loaded,
right? I don't think those additional 20k fatten the cow
(as we say in German).
next prev parent reply other threads:[~2017-05-23 9:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 13:37 [PATCH 0/6] More MMC block core refactorings Linus Walleij
2017-05-19 13:37 ` [PATCH 1/6] mmc: block: remove req back pointer Linus Walleij
2017-05-19 13:37 ` [PATCH 2/6] mmc: block: Tag DRV_OPs with a driver operation type Linus Walleij
2017-05-19 13:37 ` [PATCH 3/6] mmc: block: Move DRV OP issue function Linus Walleij
2017-05-19 13:37 ` [PATCH 4/6] mmc: block: Move boot partition locking into a driver op Linus Walleij
2017-05-19 13:37 ` [PATCH 5/6] mmc: debugfs: Move card status retrieveal into the block layer Linus Walleij
2017-05-22 7:42 ` Ulf Hansson
2017-05-23 9:49 ` Linus Walleij
2017-05-23 9:52 ` Christoph Hellwig [this message]
2017-05-23 10:17 ` Arnd Bergmann
2017-05-23 11:22 ` Ulf Hansson
2017-05-23 11:29 ` Arnd Bergmann
2017-05-23 11:04 ` Ulf Hansson
2017-05-19 13:37 ` [PATCH 6/6] mmc: debugfs: Move EXT CSD debugfs acces to " Linus Walleij
2017-05-22 12:05 ` [PATCH 0/6] More MMC block core refactorings Ulf Hansson
2017-05-22 12:44 ` Avri Altman
2017-05-22 12:44 ` Avri Altman
2017-05-22 12:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523095222.GA25307@lst.de \
--to=hch@lst.de \
--cc=Avri.Altman@sandisk.com \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=b.zolnierkie@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.