All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Fuzzey <mfuzzey@parkeon.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] firmware: request_firmware() should propagate -ERESTARTSYS
Date: Tue, 23 May 2017 15:16:07 +0200	[thread overview]
Message-ID: <20170523131607.28138.12306.stgit@localhost> (raw)

When -ERESTARTSYS is returned by wait_* due to a signal this should
be returned from request_firmware() so that the syscall may be
restarted if necessary.

Without this it is not possible to distinguish the case of
request_firmware() failing due to a timeout with that due to a signal.

In my particular case request_firmware() was being called from
a sysfs .store() callback and the writing process was the
Android init process which received a SIGCHLD causing
request_firmware() to fail.

Signed-off-by: Martin Fuzzey <mfuzzey@parkeon.com>
---
 drivers/base/firmware_class.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index b616bf7..13ed62f 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -1023,9 +1023,10 @@ static int _request_firmware_load(struct firmware_priv *fw_priv,
 		mutex_unlock(&fw_lock);
 	}
 
-	if (fw_state_is_aborted(&buf->fw_st))
-		retval = -EAGAIN;
-	else if (buf->is_paged_buf && !buf->data)
+	if (fw_state_is_aborted(&buf->fw_st)) {
+		if (retval != -ERESTARTSYS)
+			retval = -EAGAIN;
+	} else if (buf->is_paged_buf && !buf->data)
 		retval = -ENOMEM;
 
 	device_del(f_dev);

             reply	other threads:[~2017-05-23 13:49 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-23 13:16 Martin Fuzzey [this message]
2017-05-23 13:31 ` [PATCH] firmware: request_firmware() should propagate -ERESTARTSYS Greg Kroah-Hartman
2017-05-23 14:32   ` Martin Fuzzey
2017-05-23 19:55     ` Luis R. Rodriguez
2017-05-24 20:56       ` Luis R. Rodriguez
2017-05-24 21:40         ` [PATCH v2] firmware: fix sending -ERESTARTSYS due to signal on fallback Luis R. Rodriguez
2017-05-24 22:00           ` Andy Lutomirski
2017-05-24 22:38             ` Luis R. Rodriguez
2017-05-24 22:38               ` Luis R. Rodriguez
2017-05-25  4:13               ` Andy Lutomirski
2017-05-25  4:13                 ` Andy Lutomirski
     [not found]                 ` <CALCETrU4__YUGk36PN=FbuEf0SBaTrxQQqm4sWs2NrZ+6WN7jA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-25  8:28                   ` Fuzzey, Martin
2017-05-25  8:28                     ` Fuzzey, Martin
2017-05-26 11:09                     ` Eric W. Biederman
2017-05-26 11:09                       ` Eric W. Biederman
     [not found]                       ` <87fufr3mdy.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2017-05-26 19:46                         ` Luis R. Rodriguez
2017-05-26 19:46                           ` Luis R. Rodriguez
2017-05-26 21:26                           ` Dmitry Torokhov
2017-05-26 21:26                             ` Dmitry Torokhov
     [not found]                             ` <CAKdAkRTrcTVOAP5GK-R=Au_tL5WqSn5UkQEzNe5NcCWXS8mbtA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-26 21:32                               ` Luis R. Rodriguez
2017-05-26 21:32                                 ` Luis R. Rodriguez
2017-05-26 21:55                                 ` Dmitry Torokhov
2017-05-26 21:55                                   ` Dmitry Torokhov
2017-06-05 20:24                                   ` Luis R. Rodriguez
2017-06-05 20:24                                     ` Luis R. Rodriguez
     [not found]                                     ` <20170605202410.GQ8951-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2017-06-06  9:04                                       ` Martin Fuzzey
2017-06-06  9:04                                         ` Martin Fuzzey
     [not found]                                         ` <59367025.3020901-mB3Nsq4MPf1BDgjK7y7TUQ@public.gmane.org>
2017-06-06 16:34                                           ` Luis R. Rodriguez
2017-06-06 16:34                                             ` Luis R. Rodriguez
     [not found]                                             ` <20170606163401.GA27288-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2017-06-06 17:52                                               ` Luis R. Rodriguez
2017-06-06 17:52                                                 ` Luis R. Rodriguez
2017-06-06 14:53                                       ` Alan Cox
2017-06-06 14:53                                         ` Alan Cox
     [not found]                                         ` <1496760796.5682.48.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-06-06 16:47                                           ` Luis R. Rodriguez
2017-06-06 16:47                                             ` Luis R. Rodriguez
     [not found]                                             ` <20170606164734.GB27288-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2017-06-06 17:54                                               ` Luis R. Rodriguez
2017-06-06 17:54                                                 ` Luis R. Rodriguez
2017-06-06 22:11                                             ` Theodore Ts'o
2017-06-06 22:11                                               ` Theodore Ts'o
     [not found]                                               ` <20170606221151.ygoxqkwhhjsqw632-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>
2017-06-07  0:22                                                 ` Luis R. Rodriguez
2017-06-07  0:22                                                   ` Luis R. Rodriguez
     [not found]                                                   ` <20170607002237.GJ27288-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2017-06-07  4:56                                                     ` Andy Lutomirski
2017-06-07  4:56                                                       ` Andy Lutomirski
2017-06-07  6:25                                                       ` Dmitry Torokhov
2017-06-07  6:25                                                         ` Dmitry Torokhov
2017-06-07 12:25                                                         ` Alan Cox
2017-06-07 12:25                                                           ` Alan Cox
2017-06-07 17:15                                                           ` Luis R. Rodriguez
2017-06-07 17:15                                                             ` Luis R. Rodriguez
2017-06-09  1:14                                                         ` Andy Lutomirski
2017-06-09  1:14                                                           ` Andy Lutomirski
     [not found]                                                           ` <CALCETrXbHpkN9Pujj=U1VpAR9MTOyCAqCtL0=7-vb1EdpEwCMg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-09  1:33                                                             ` Luis R. Rodriguez
2017-06-09  1:33                                                               ` Luis R. Rodriguez
     [not found]                                                               ` <CAB=NE6USSj0sBzJSFOyyRQu=0rQXdbHc2+GNk1fse+Y8H6TrgQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-09 21:29                                                                 ` Luis R. Rodriguez
2017-06-09 21:29                                                                   ` Luis R. Rodriguez
     [not found]                     ` <CANh8QzwPb_+RKs5QVt7mdFk8h_rOMVS3j9m0OADgvzBtNqBBLg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-26 19:40                       ` Luis R. Rodriguez
2017-05-26 19:40                         ` Luis R. Rodriguez
     [not found]                         ` <20170526194001.GR8951-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2017-05-26 20:23                           ` Fuzzey, Martin
2017-05-26 20:23                             ` Fuzzey, Martin
     [not found]                             ` <CANh8QzyqQ5hubWJvWYxgoQ3baL6sgoQPSzEHMY0tu8WNGS2gZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-26 20:52                               ` Luis R. Rodriguez
2017-05-26 20:52                                 ` Luis R. Rodriguez
2017-06-07 17:08                       ` Luis R. Rodriguez
2017-06-07 17:08                         ` Luis R. Rodriguez
2017-06-07 17:54                         ` Martin Fuzzey
2017-06-07 17:54                           ` Martin Fuzzey
     [not found]                           ` <59383DDA.3040702-mB3Nsq4MPf1BDgjK7y7TUQ@public.gmane.org>
2017-06-09  1:10                             ` Luis R. Rodriguez
2017-06-09  1:10                               ` Luis R. Rodriguez
2017-06-09  1:57                               ` Luis R. Rodriguez
2017-06-09  1:57                                 ` Luis R. Rodriguez
     [not found]                                 ` <CAB=NE6UQZMmLvxTu7RcFHh3neAh+RFpTTFCSwJ8_EsmmtEq94Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-09  7:40                                   ` Martin Fuzzey
2017-06-09  7:40                                     ` Martin Fuzzey
     [not found]                                     ` <593A50FF.40604-mB3Nsq4MPf1BDgjK7y7TUQ@public.gmane.org>
2017-06-09 21:12                                       ` Luis R. Rodriguez
2017-06-09 21:12                                         ` Luis R. Rodriguez
2017-06-09 22:55                                     ` Luis R. Rodriguez
2017-06-09 22:55                                       ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170523131607.28138.12306.stgit@localhost \
    --to=mfuzzey@parkeon.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.