Re: [PATCH 1/3] usb: host: ohci-platform: Add basic runtime PM support

[Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>]

* Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org> [170523 00:14]:
> On 22/05/17 19:00, Tony Lindgren wrote:
> > --- a/drivers/usb/host/ohci-platform.c
> > +++ b/drivers/usb/host/ohci-platform.c
> > @@ -290,7 +294,14 @@ static int ohci_platform_remove(struct platform_device *dev)
> >  	struct usb_hcd *hcd = platform_get_drvdata(dev);
> >  	struct usb_ohci_pdata *pdata = dev_get_platdata(&dev->dev);
> >  	struct ohci_platform_priv *priv = hcd_to_ohci_priv(hcd);
> > -	int clk, rst;
> > +	int clk, rst, enabled;
> > +
> > +	enabled = pm_runtime_get_sync(&dev->dev);
> 
> Why do we need to pm_runtime_get_sync() here?

ohci_platform_remove()
	usb_remove_hcd()
		ohci_stop()

Will cause "external abort on non-linefetch" otherwise.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html